Sorry, I think it’s a good tech topic to discuss, so forward it to crosswalk-dev. From: Wang, Peter H Sent: Friday, October 25, 2013 11:42 AM To: crosswalk-project/crosswalk; crosswalk-project/crosswalk Subject: RE: [crosswalk] Use empty name to inject JS to avoid revealing code. (#828)
The part of JS code we try to hide is the helper to setup binding rather than JS code of web content. Taking this case as example, do we need to know the js “document.getElementById” to invoke according c++ interface? No. This part is implemented by JS due to architecture convenience and bring some flexibility by my understanding. Actually, it can be implemented by c++ so there is not that sort of problem, but lose some benefits. It happened I involved in some project like what Camrcelo is doing. The basic architecture of design doesn’t being used first time in this world. Means, it’s verified by some people before. I trust it, based on my knowledge. My patch is a little work to help it being strong. Actually, I’m trying to find another “hole” and then fill it. The eventual purpose is to do a little help to make it success. From: Hongbo Min [mailto:[email protected]] Sent: Friday, October 25, 2013 11:16 AM To: crosswalk-project/crosswalk Cc: Wang, Peter H Subject: Re: [crosswalk] Use empty name to inject JS to avoid revealing code. (#828) @PeterWangIntel<https://github.com/PeterWangIntel> @cmarcelo<https://github.com/cmarcelo> Post comments: I am curious what is the intention of this PR to avoid revealing code. Revealing the JS code into devtools panel is helpful to both Crosswalk developer and app developer. It allows the developer to debug the JS code. Otherwise, it is hard to identify the failures in JS code. For app developers, the JS code could give them a chance to find out the potential bug inside Crosswalk. Since Crosswalk is an open source project, why do we need to hide the JS code? What's the benefits? — Reply to this email directly or view it on GitHub<https://github.com/crosswalk-project/crosswalk/pull/828#issuecomment-27055566>.
_______________________________________________ Crosswalk-dev mailing list [email protected] https://lists.crosswalk-project.org/mailman/listinfo/crosswalk-dev
