For Android related patches reviewed by me, I'll take care about their trybot results and judge the impact if old regressions broke tests before merging them.
However, obviously not all patches which impact Android port get working in that way. Please be free to ping me if you're not sure about Android port. Yongsheng From: Crosswalk-dev [mailto:[email protected]] On Behalf Of Zhu, Yongsheng Sent: Tuesday, November 26, 2013 9:45 AM To: Oliveira, Caio; [email protected] Subject: Re: [Crosswalk-dev] Trybots running Android tests? Caio, Android trybots are enabled correctly. Actually there were some issues after rebasing to Chromium32 but we fixed them. Last week, two PRs broke the Android trybots. One is from Tizen PR#1121. It broke all unit tests. See the bot results<http://wrt-buildbot.bj.intel.com/buildbot/builders/xwalk_android/builds/2014/>. This could be avoided if the owner and reviewer could check the bot results because the trybot was green before that. Another PR is from extension PR #1080. It's a big patch and it broke unit tests for extensions(One of Android trybot failed due to lack of storage on Android devices so Thiago didn't know how to judge the results). We quickly cleaned up the Android devices and the regressions was found in trybot. You could see I reported the JIRA issue XWALK-446 aftewards. Currently all unit tests are passed in Android trybots after Thiago's fix for the regression. http://wrt-buildbot.bj.intel.com/buildbot/builders/xwalk_android/builds/2085 If someone breaks Android trybots, owners please don't merge his PR. Yongsheng > -----Original Message----- > From: Crosswalk-dev [mailto:[email protected]] > On Behalf Of Caio Marcelo de Oliveira Filho > Sent: Monday, November 25, 2013 9:28 PM > To: > [email protected]<mailto:[email protected]> > Subject: [Crosswalk-dev] Trybots running Android tests? > > Hello, > > How hard would be to get the Android trybot to run the automated tests? Are > there any blockers to get that? > > It would be very helpful since Crosswalk for Android have a lot of different > code > paths and not everyone is working actively on Android. I can recall recently > at > least two occurences that broke Android testing that could be prevented by > running the tests on trybots -- giving enough information to original > developers > to fix it. > > > Cheers, > Caio > _______________________________________________ > Crosswalk-dev mailing list > [email protected]<mailto:[email protected]> > https://lists.crosswalk-project.org/mailman/listinfo/crosswalk-dev
_______________________________________________ Crosswalk-dev mailing list [email protected] https://lists.crosswalk-project.org/mailman/listinfo/crosswalk-dev
