Hi Caio, Thanks for your comments:
Q: The proposal is missing the targetted Crosswalk release A: Need to figure it out :) Q: The proposal is missing the "planned steps". Even if it's a draft plan, it would be helpful for me, and possibly for others. A: Let me add it to the doc Q: CmdLineStrategy: it seems the goal here is to decouple any action specific of Crosswalk from the ContentBrowserClient code. Wouldn't suffice for the beginning to simply call ApplicationSystem with the command line to handle? If needed later we can add strategy logic there. A: OK, let's remove CmdLineStrategy Q: I still fail to see the need for ApplicationPageDisplayStrategy, could you elaborate more? Is it just a detail of implementation of XWalkApplication or is it needed by the design? If it's an detail I suggest postponing this. A: The problem that I'm trying to solve is that Runtime is creating a NativeAppWindow itself and also places itself there. I find it wrong and I do not want ApplicationPage to contain this logic. What if we want to render each page on a new tab instead of creating a new window each time? Or maybe on some platforms we want to display all pages related to the same application as tabs on the same window and have a new window per application, so there has to be someone containing this logic. In the proposal design it is ApplicationPageDisplayStrategy. Q: Is there any dependency between this work and the work being done inside ApplicationStore? I'm assuming no, but it's nice to have it cleared. A: I think renaming Application to ApplicationData is the only dependency :) So I guess both improvements can be done simultaneously Q: Who will own ApplicationData or will it remain a refcounted object? A: It will remain a refcounted object -> its ownership is spread between applications and application storage. BR, Mikhail ________________________________________ From: Oliveira, Caio Sent: Tuesday, November 26, 2013 7:17 PM To: Pozdnyakov, Mikhail Cc: crosswalk-dev@lists.crosswalk-project.org Subject: Re: [Crosswalk-dev] Intent to Implement: XWalk runtime&application classes re-design Hi Mikhail and Alex, "Decouple Chromium content API integration and xwalk runtime logic classes", I think now I understand and agree with this point :-) The plan is that the main classes in Crosswalk are classes of our own, instead of piggingback in objects like the clients, that do exist (possibly with the lifetime we desire) but are more structured to serve Chromium Content API. Assuming the above interpretation is correct, LGTM with the comments below. - The proposal is missing the targetted Crosswalk release. - The proposal is missing the "planned steps". Even if it's a draft plan, it would be helpful for me, and possibly for others. - CmdLineStrategy: it seems the goal here is to decouple any action specific of Crosswalk from the ContentBrowserClient code. Wouldn't suffice for the beginning to simply call ApplicationSystem with the command line to handle? If needed later we can add strategy logic there. - I still fail to see the need for ApplicationPageDisplayStrategy, could you elaborate more? Is it just a detail of implementation of XWalkApplication or is it needed by the design? If it's an detail I suggest postponing this. - Is there any dependency between this work and the work being done inside ApplicationStore? I'm assuming no, but it's nice to have it cleared. - Who will own ApplicationData or will it remain a refcounted object? Congrats, I'm confident that these changes will achieve the intended goals. Cheers, Caio --------------------------------------------------------------------- Intel Finland Oy Registered Address: PL 281, 00181 Helsinki Business Identity Code: 0357606 - 4 Domiciled in Helsinki This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. _______________________________________________ Crosswalk-dev mailing list Crosswalk-dev@lists.crosswalk-project.org https://lists.crosswalk-project.org/mailman/listinfo/crosswalk-dev
