On 18/01/14 05:24, Jesus Sanchez-Palencia wrote:
Hi,
on the regard of where we store icons in our XPK packages, it came to
our attention today that all the packages we have seen so far are
probably wrong. (or at least wrongly defined on their manifest).
Let's use HangOnMan [1] as an example, so we can settle this now. Its
manifest file [2] says:
"icons": {
"16": "icon_16.png",
"48": "icon_64.png",
"128": "icon_128.png"
},
and we can find those icon files inside this app's src/ folder.
However, after having a look at how both Chrome apps [3] and W3C
Widgets Spec [4] are handling this, we can see that they provide icon
paths rather just icon names, since an app root is always where the
manifest file sits.
In other words, for our XPK packages the manifest should say:
"icons": {
"16": "src/icon_16.png",
"48": "src/icon_64.png",
"128": "src/icon_128.png"
},
Well, in the upstream, they're in the root, so the manifest file is
correct :
<https://github.com/01org/webapps-hangonman/releases/download/v0.0.4/HangOnMan_0.0.4.xpk>
"[HangOnMan]$ ls
audio data icon_16.png images js LICENSE manifest.json
css icon_128.png icon_48.png index.html lib _locales README.txt
[HangOnMan]$ cat manifest.json
{
...
"icons": {
"128": "icon_128.png",
"48": "icon_48.png",
"16": "icon_16.png"
},
...
}
"
There is no src directory at all.
I'm not sure what is happening with crosswalk-demos. IINM, they use git
submodules, which I dislike but which should have ensured they get the
latest code - IINM, they apply some patches on top though...it's a mess,
imo.
This has just blocked us from merging a tool capable of correctly
installing both WGT and XPK packages on Tizen.
The upstream also has prebuilt wgt packges :
<https://github.com/01org/webapps-hangonman/releases>
I believe we should fix all of our manifest files now so we don't
propagate this issue any further. What do you think?
All 19 webapps work correctly, imo. I've attempted to make them part of
crosswalk-demos, but the owners of that insist on using python to
package them and haven't adapted it to build the apps properly.
I don't think there's any misunderstanding in general.
I suggest you use the packages directly from upstream until the
crosswalk-demos is fixed.
Max.
_______________________________________________
Crosswalk-dev mailing list
[email protected]
https://lists.crosswalk-project.org/mailman/listinfo/crosswalk-dev
