Awesome. Thank you for your effort :)

DS


On Wed, Feb 19, 2014 at 8:52 PM, Raphael Kubo da Costa <
[email protected]> wrote:

> Hi, everyone,
>
> Consider our trees open after Crosswalk commit
> 7043e894eab2aa6b578464f5f5348c49cb7e9643.
>
> Pending items
> =============
> The Android build is broken because pull request #1539 does not work
> with M34 [1] and I don't know whether it makes sense to revert it. I
> think it can be easily solved tomorrow by the PRC team, we just won't
> have canaries tonight.
>
> [1]
> https://build.crosswalk-project.org/builders/Crosswalk%20Android-X86/builds/549
>
> The DisplayInfoProvider test is consistently failing on the Linux bot,
> someone with a sysapps hat needs to take a look at it.
>
> What could be solved today
> ==========================
>
> Rebasing chromium- and blink-crosswalk worked just fine, and the content
> shell bots in build.crosswalk-project.org built the new version without
> problems.
>
> The Crosswalk rebase was more troublesome, though, mainly because I had
> been told so far that Android was in a working state when it wasn't:
> gyp_xwalk had to be adapted to take into account all the changes that
> had been done to gyp_chromium (ie. all the GN changes), otherwise gyp
> would not even recognize that it should create an Android build at all
> [2][3].
>
> [2]
> https://build.crosswalk-project.org/builders/Crosswalk%20Android-X86/builds/544
> [3]
> https://github.com/crosswalk-project/crosswalk/commit/fd33e5b97a63b4ae7d9471e393d4c86dd8ddd2f2
>
> To make things worse, fixing the Android build caused the Tizen build to
> fail due to GN looking for too many dependencies (and the GN binaries
> themselves carrying too many dependencies in this Chromium version we
> are tracking). I've had to add some workarounds to avoid calling GN when
> using make for now.
>
> It's clear that we have to address a few things soon:
>
> * Maintaining gyp_xwalk as it is is not scaling well in this period
>   where there are so many GN changes happening upstream.
> * The make gyp generator is already in life-support mode upstream and we
>   should not count on it for long. Now that we do not need to care about
>   Tizen 2 anymore, we should consider creating a Tizen RPM for ninja and
>   start experimenting with it (it will cause problems with incremental
>   Tizen builds, though, due to ninja expecting the build directory to be
>   out/).
> * We will have to work with upstream so that we're able to remove the
>   Tizen workarounds from gyp_xwalk; namely, someone needs to investigate
>   how to make GN stop considering that a Linux build requires GTK+ and
>   friends and also find a way to stop importing find_depot_tools
>   unconditionally (we should not need depot_tools in the Tizen chroot, I
>   think).
>
> I will create JIRA tickets for those items tomorrow.
>
> Once again, I'd like to thank everyone who helped with the rebasing
> efforts.
>
> P.S.: Android folks: don't take this message as me blaming you, it is
> just a report of what happened and I really think the Android bots will
> be green tomorrow.
> _______________________________________________
> Crosswalk-dev mailing list
> [email protected]
> https://lists.crosswalk-project.org/mailman/listinfo/crosswalk-dev
> ---------------------------------------------------------------------
> Intel Finland Oy
> Registered Address: PL 281, 00181 Helsinki
> Business Identity Code: 0357606 - 4
> Domiciled in Helsinki
>
> This e-mail and any attachments may contain confidential material for
> the sole use of the intended recipient(s). Any review or distribution
> by others is strictly prohibited. If you are not the intended
> recipient, please contact the sender and delete all copies.
>
>
_______________________________________________
Crosswalk-dev mailing list
[email protected]
https://lists.crosswalk-project.org/mailman/listinfo/crosswalk-dev

Reply via email to