Re-submitted the missing patches(in PR#115) in https://github.com/crosswalk-project/chromium-crosswalk/pull/125. @Kenneth, please help review and merge.
-----Original Message----- From: Crosswalk-dev [mailto:[email protected]] On Behalf Of Zhu, Yongsheng Sent: Thursday, February 20, 2014 1:50 PM To: Kubo Da Costa, Raphael; [email protected] Subject: Re: [Crosswalk-dev] M34 rebase completed Really thank you for doing this, Raphael. The main problem of failing to build Android is because 'next' branch is rebased to Crosswalk the day before yesterday but seems it's not done for Chromium-Crosswalk as well. As a result, the patches in Chromium-Crosswalk were missed. So our investigation is yes, it's related to PR#1539: For XWALK-880: One PR(#115 for Chromium-crosswalk) was landed firstly and another PR(#1539) depends on #115 and then was landed after that(all merged by Kenneth the day before yesterday). PR #115 was lost in current Chromium-crosswalk master. We'll re-submit the patches for Chromium side today. Thanks. Yongsheng > -----Original Message----- > From: Crosswalk-dev > [mailto:[email protected]] > On Behalf Of Raphael Kubo da Costa > Sent: Thursday, February 20, 2014 2:53 AM > To: [email protected] > Subject: [Crosswalk-dev] M34 rebase completed > > Hi, everyone, > > Consider our trees open after Crosswalk commit > 7043e894eab2aa6b578464f5f5348c49cb7e9643. > > Pending items > ============= > The Android build is broken because pull request #1539 does not work > with M34 [1] and I don't know whether it makes sense to revert it. I > think it can be easily solved tomorrow by the PRC team, we just won't have > canaries tonight. > > [1] > https://build.crosswalk-project.org/builders/Crosswalk%20Android-X86/b > uilds/5 > 49 > > The DisplayInfoProvider test is consistently failing on the Linux bot, > someone with a sysapps hat needs to take a look at it. > > What could be solved today > ========================== > > Rebasing chromium- and blink-crosswalk worked just fine, and the > content shell bots in build.crosswalk-project.org built the new version > without problems. > > The Crosswalk rebase was more troublesome, though, mainly because I > had been told so far that Android was in a working state when it wasn't: > gyp_xwalk had to be adapted to take into account all the changes that > had been done to gyp_chromium (ie. all the GN changes), otherwise gyp > would not even recognize that it should create an Android build at all [2][3]. > > [2] > https://build.crosswalk-project.org/builders/Crosswalk%20Android-X86/b > uilds/5 > 44 > [3] > https://github.com/crosswalk-project/crosswalk/commit/fd33e5b97a63b4ae > 7d9 > 471e393d4c86dd8ddd2f2 > > To make things worse, fixing the Android build caused the Tizen build > to fail due to GN looking for too many dependencies (and the GN > binaries themselves carrying too many dependencies in this Chromium > version we are tracking). I've had to add some workarounds to avoid calling > GN when using make for now. > > It's clear that we have to address a few things soon: > > * Maintaining gyp_xwalk as it is is not scaling well in this period > where there are so many GN changes happening upstream. > * The make gyp generator is already in life-support mode upstream and we > should not count on it for long. Now that we do not need to care about > Tizen 2 anymore, we should consider creating a Tizen RPM for ninja and > start experimenting with it (it will cause problems with incremental > Tizen builds, though, due to ninja expecting the build directory to be > out/). > * We will have to work with upstream so that we're able to remove the > Tizen workarounds from gyp_xwalk; namely, someone needs to investigate > how to make GN stop considering that a Linux build requires GTK+ and > friends and also find a way to stop importing find_depot_tools > unconditionally (we should not need depot_tools in the Tizen chroot, I > think). > > I will create JIRA tickets for those items tomorrow. > > Once again, I'd like to thank everyone who helped with the rebasing efforts. > > P.S.: Android folks: don't take this message as me blaming you, it is > just a report of what happened and I really think the Android bots will be > green tomorrow. > _______________________________________________ > Crosswalk-dev mailing list > [email protected] > https://lists.crosswalk-project.org/mailman/listinfo/crosswalk-dev _______________________________________________ Crosswalk-dev mailing list [email protected] https://lists.crosswalk-project.org/mailman/listinfo/crosswalk-dev _______________________________________________ Crosswalk-dev mailing list [email protected] https://lists.crosswalk-project.org/mailman/listinfo/crosswalk-dev
