Hi, If you are not a committer or an OWNER of one of the crosswalk repositories you can stop read now.
Quick state of art : Github push access and admin access are granted through a team system. If you want to add someone as a committer you add his github account to that team and you make sure that the team is listed in the "Collaborators" section of the settings for a given repository. In the past we had a very monolithic way of managing who gets push/admin access of the crosswalk project repositories. Beside few infra and management bits we had 2 groups : committers (with push rights) and owners (who reflect mostly the OWNERS of crosswalk but with the admin bits of github so they can modify repository settings and groups). These two groups were used to control the rights of all repositories under the crosswalk-project umbrella. With crosswalk-project growing up and a lot of repositories have been added it's not going to fly long. For example you may want to grant access to a contributor in our cordova work because he has been doing an amazing job, however giving him access to crosswalk without him being familiar is kind of overkill and dangerous. So as today each repository (mostly) have his own group of committers and owners and are not shared with other repos. I reflected the current situation the best I could for each repo. If you happen to have lost some rights, please let me know I will fix it right away. The owners of these repo can add at will committers or owners but again we should go through the normal ML process for nomination. ** Team crosswalk-tools-committers and crosswalk-tools-owners are associated with these repositories : - crosswalk-demos - crosswalk-sample - crosswalk-apk-generator - grunt-crosswalk - crosswalk-developer-tools-eclipse-plugin ** Team crosswalk-cordova-committers and crosswalk-cordova-owners are associated with the repository crosswalk-cordova-android ** Team crosswalk-test-suite-committers and crosswalk-test-suite-owners are associated with the repository crosswalk-test-suite ** Team crosswalk-website-committers and crosswalk-website-owners are associated with the repository crosswalk-website ** Team tizen-extensions-crosswalk-committers and tizen-extensions-crosswalk-owners are associated with the repository tizen-extensions-crosswalk. ** Team Chromium-Branches-Owners is associated to chromium-crosswalk, blink-crosswalk and v8-crosswalk ** Team crosswalk-owners and crosswalk-committers are associated to crosswalk.git repository. Few considerations : - Crosswalk Owners do not have admin rights on other repositories anymore, only on crosswalk.git itself. You can have admin rights on another repository if you become an OWNER there. I felt it was right to do so, at the end for example I'm not the best person to admin the crosswalk-website repository, Elliot is. I suggest that repository owners start landing an OWNER file in their repo so that people know who to contact to get review (can be a root OWNER file for now) : crosswalk-demos, crosswalk-sample, crosswalk-apk-generator, grunt-crosswalk, crosswalk-developer-tools-eclipse-plugin, crosswalk-cordova-android, t-c-e, crosswalk-website needs one. - Crosswalk committers have push access to all repositories just like before (exception of our downstream forks [1]). This doesn't mean you can land like a cowboy and not following the rules, you should still get LGTM from an OWNER. I believe that when you become a crosswalk.git committer you're well aware of the process and you can land yourself reviewed patches on any crosswalk repositories. - Few of us have a special "admin" account where we can manage the entire crosswalk-project organization, this explains why they can merge/admin all repositories. These persons are well aware of all our processes and should not abuse the admin rights and the green merge button. Any feedback? Are you ok with the new setup? [1] Our downstream forks are quite special to handle. Beside merging a given patch there is various considerations that are handled by the branch owners (infra, branching...) so that's why push rights are not granted there. -- Alexis Menard _______________________________________________ Crosswalk-dev mailing list [email protected] https://lists.crosswalk-project.org/mailman/listinfo/crosswalk-dev
