Yes, I think this is reasonable, I'll update the pull request later. From: Balestrieri, Francesco Sent: Thursday, July 3, 2014 12:36 PM To: Hur, Joone; Liu, Shouqun; [email protected] Subject: RE: Adding WebUI to Crosswalk
Can we add Web UI support only for Tizen, at least for now? From: Crosswalk-dev [mailto:[email protected]] On Behalf Of Hur, Joone Sent: Thursday, July 03, 2014 6:27 AM To: Liu, Shouqun; [email protected]<mailto:[email protected]> Subject: Re: [Crosswalk-dev] Adding WebUI to Crosswalk Hi Shougun, Yes, the file-picker WebUI started to work since I applied your patch. o/ Regarding WebUI support in Crosswalk, it is needed for Tizen IVI. As you may know, Chromium only supports Gtk+ file-picker on Linux platform, but it is Gtk+2 version so it doesn't work in Wayland. That's why I'm trying to use WebUI for file-picker on TizenIVI. If we only use WebUI for file-picker, we don't need it for Android that already has a file picker provided by Android platform. However, WebUI seems to be very useful to add system menu such as settings and help. Thank you for solving this problem. Joone From: Liu, Shouqun Sent: Wednesday, July 02, 2014 7:11 PM To: [email protected]<mailto:[email protected]>; Hur, Joone Subject: RE: Adding WebUI to Crosswalk Hi Joone, The root cause of WebUI does not work is that some webui resources (ui/webui/resources/*) are not packed into the Crosswalk pak file. I have send a pull request (https://github.com/crosswalk-project/crosswalk/pull/2163 ) to fix this (chrome://gpu works, so I think chrome://file-picker should also work). But it's still worth to discuss that whether we should support WebUI? Since WebUI and "chrome://" schema are Chrome features, are they meaningful to Crosswalk? Also adding the WebUI will increase binary size about 150KB (Android APK). Your comments are welcome. Thanks, Shouqun From: Crosswalk-dev [mailto:[email protected]] On Behalf Of Hur, Joone Sent: Thursday, July 03, 2014 7:14 AM To: [email protected]<mailto:[email protected]> Subject: [Crosswalk-dev] Adding WebUI to Crosswalk Hi, I'm working on File-picker for Crosswalk and Chromium(Ozone-wayland) using WebUI. https://crosswalk-project.org/jira/browse/XWALK-950 https://github.com/01org/ozone-wayland/issues/147 The file-picker WebUI works fine in Chromium, but it doesn't work in Crosswalk because shared JS files(src/ui/webui/resources/js) don't run as follows: [0701/172113:ERROR:CONSOLE(0)] "Uncaught TypeError: Cannot convert undefined or null to object", source: chrome://file-picker/ (0) [0701/172113:ERROR:CONSOLE(1)] "Uncaught ReferenceError: loadTimeData is not defined", source: chrome://file-picker/strings.js (1) [0701/172113:ERROR:CONSOLE(7)] "Uncaught ReferenceError: cr is not defined", source: chrome://file-picker/file_picker.js (7) There seems to be missing things for WebUI in Crosswalk. Here are my patches for Crosswalk: https://github.com/joone/chromium-crosswalk/commit/66ac6238b2f8ec7a05c50e44a682d42f03cc5e04 https://github.com/joone/crosswalk/commit/3008dbcb4fd068dae309863cd9a8f1bc22938c4d https://github.com/joone/ozone-wayland/commit/963cf6b0b66c308f3da5158c303b164c1695aa28 Actually, there are several WebUIs in Crosswalk. Of course, they don't work now due to missing WebUI support. https://github.com/joone/chromium-crosswalk/blob/66ac6238b2f8ec7a05c50e44a682d42f03cc5e04/content/public/common/url_constants.cc After applying my patches, you can try to open chrome://file-picker and chrome://gpu. chrome://gpu also has the same problem. I think that it is important to support WebUI for Crosswalk: We can provide system dialog boxes (file-picker or printing) and system menu (settings or help) like Chromium. If you have any idea why WebUI doesn't work in Crosswalk, please let me know. Thanks, Joone
_______________________________________________ Crosswalk-dev mailing list [email protected] https://lists.crosswalk-project.org/mailman/listinfo/crosswalk-dev
