LGTM!
From: Crosswalk-dev [mailto:crosswalk-dev-boun...@lists.crosswalk-project.org]
On Behalf Of Spencer, Bob
Sent: Wednesday, August 27, 2014 2:27 AM
To: Wang, Shiliu; 'Zhu, Yongsheng'
Cc: crosswalk-dev@lists.crosswalk-project.org
Subject: [Crosswalk-dev] Intent to Implement -- make_apk.py (and related)
script improvements
Description:
There are a handful of things I'd like to improve in the current python
build/bundle scripts. Specifically:
- Allow make_apk.py to be runnable from any directory, not just
from the crosswalk directory
- Improve the language and printed output from the scripts
- Create the temporary directories in the system "temp"
location so if the script is interrupted they don't clutter the crosswalk
source directory
Affected component:
- source changes: Python scripts in src/xwalk/app/
- area of project affected: Crosswalk command-line builds
Related features/bugs: XWALK-2391 -
2395<https://crosswalk-project.org/jira/browse/XWALK-2395?jql=id%20in%20%28XWALK-2391%2C%20XWALK-2392%2C%20XWALK-2393%2C%20XWALK-2394%2C%20XWALK-2395%29>
Implementation details:
To allow make_apk.py to be runnable from any directory, identify all the places
where scripts are imported or files/directories are read/written and pre-pend
the xwalk directory. The main changes are in make_apk.py and customize.py with
a couple one-line changes in the few other scripts. (I think!)
For example:
(at head of script)
# get xwalk absolute path so we can run this script from any location
xwalk_dir = os.path.dirname(os.path.abspath(__file__))
(then to load additional .py)
sys.path.append(xwalk_dir)
(or to access files/directories)
target_library_path = os.path.join(xwalk_dir, name, 'xwalk_core_library')
Bob
---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki
Business Identity Code: 0357606 - 4
Domiciled in Helsinki
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
_______________________________________________
Crosswalk-dev mailing list
Crosswalk-dev@lists.crosswalk-project.org
https://lists.crosswalk-project.org/mailman/listinfo/crosswalk-dev
