LGTM! On Thu, Sep 11, 2014 at 10:19 AM, Han, YangangX <yangangx....@intel.com> wrote:
> I see, thank you. > > Then we just make the same page to work for Crosswalk, is that ok for you? > It just needs one or two day, then our devtools will look better. > > > > *From:* Kenneth Rohde Christiansen [mailto:kenneth.christian...@gmail.com] > > *Sent:* Thursday, September 11, 2014 3:53 PM > *To:* Han, YangangX > *Cc:* Pozdnyakov, Mikhail; crosswalk-dev@lists.crosswalk-project.org; > Wang, Peter H; Menard, Alexis > > *Subject:* Re: [Crosswalk-dev] Intent To Implement - Improve discovery > page of devtools for Tizen Crosswalk > > Yes, we should follow that, because that is what users are used to and > what will be documented in most tutorials :-) > > > > I am OK with your improving the current state, but I don't see any big > need to do a lot of styling (such as background color, huge fonts etc) as > that would just make it even further away from how Chrome currently works. > > > > Kenneth > > > > On Thu, Sep 11, 2014 at 9:48 AM, Han, YangangX <yangangx....@intel.com> > wrote: > > Hi Kenneth, > > > > Thank you for your comments. Did you mean it’s better to follow the > google-chrome’s discovery page as attached image shows? It’s also ok for > me. I just think we should do some work for current devtools first page. > > > > Regards, > > Yangang > > > > > > *From:* Kenneth Rohde Christiansen [mailto:kenneth.christian...@gmail.com] > > *Sent:* Thursday, September 11, 2014 3:31 PM > *To:* Pozdnyakov, Mikhail > *Cc:* Han, YangangX; crosswalk-dev@lists.crosswalk-project.org; Wang, > Peter H; Menard, Alexis > *Subject:* Re: [Crosswalk-dev] Intent To Implement - Improve discovery > page of devtools for Tizen Crosswalk > > > > I think here is value it keeping this like how it is for Chrome, or at > least similar. Did you have a look at that? > > > > Also if we want to do something related to UI design, we should get some > designers involved as they have the right skill set. > > > > Btw, it is Crosswalk and not CrossWalk and we are getting away with the > orange branding. > > > > Kenneth > > > > On Thu, Sep 11, 2014 at 9:28 AM, Pozdnyakov, Mikhail < > mikhail.pozdnya...@intel.com> wrote: > > lgtm > > BR, > Mikhail > > ________________________________________ > From: Han, YangangX > Sent: Thursday, September 11, 2014 10:24 AM > To: crosswalk-dev@lists.crosswalk-project.org > Cc: Pozdnyakov, Mikhail; Christiansen, Kenneth R; Menard, Alexis; You, > Yongkang; Wang, Peter H; Balestrieri, Francesco > Subject: Intent To Implement - Improve discovery page of devtools for > Tizen Crosswalk > > Description: > Discovery page is the entrance of remote debugging of Applications. > Currently, the discovery page of Tizen (and Linux) Crosswalk has not any > CSS decorates. I’d like to add some basic decorates to improve user > experience. > > Affected component: Crosswalk runtime > > Related feature: XWALK-2525 > > Target release: Crosswalk v9 > > Implementation details: > We only need to modify the file > “runtime/resources/devtools_discovery_page.html” > The attached images are the snapshots of current and proposed discovery > page. > The improvements in the proposed discovery page are: > (1) Add CSS styles to decorate title, text of app debugging link, and > background of whole page. > The styles is consistent with the style of > https://crosswalk-project.org/. > (2) Add a feature to highlight the app debugging link when it’s > hovered by mouse pointer. > (3) Add favicon to help users to recognize app quickly. > If the favicon is not provided by App, default icon is Corsswalk icon. > > > > Thank you very much. > > Cheers, > YangangX Han > > > --------------------------------------------------------------------- > Intel Finland Oy > Registered Address: PL 281, 00181 Helsinki > Business Identity Code: 0357606 - 4 > Domiciled in Helsinki > > This e-mail and any attachments may contain confidential material for > the sole use of the intended recipient(s). Any review or distribution > by others is strictly prohibited. If you are not the intended > recipient, please contact the sender and delete all copies. > > _______________________________________________ > Crosswalk-dev mailing list > Crosswalk-dev@lists.crosswalk-project.org > https://lists.crosswalk-project.org/mailman/listinfo/crosswalk-dev > > > > > > -- > Kenneth Rohde Christiansen > Web Platform Architect, Intel Corporation. > Phone +45 4294 9458 ﹆﹆﹆ > > > > > > -- > Kenneth Rohde Christiansen > Web Platform Architect, Intel Corporation. > Phone +45 4294 9458 ﹆﹆﹆ > -- Kenneth Rohde Christiansen Web Platform Architect, Intel Corporation. Phone +45 4294 9458 ﹆﹆﹆
_______________________________________________ Crosswalk-dev mailing list Crosswalk-dev@lists.crosswalk-project.org https://lists.crosswalk-project.org/mailman/listinfo/crosswalk-dev