LGTM. Thanks for explanation.
> -----Original Message----- > From: He, Xinchao > Sent: Wednesday, March 11, 2015 1:57 PM > To: Huo, Halton > Cc: [email protected] > Subject: Re: [Crosswalk-dev] Intent to Implement: Replace user agent for XPK > web application > > Thanks for feedback, Halton. > > This feature is planned to support both Linux and Tizen, I'm not sure whether > Crosswalk Project for Android like this feature, but the common manifest > parser would add a handler for 'xwalk_user_agent' field, think Android also > can > use this. > > "Huo, Halton" <[email protected]> writes: > > > Seems this is only support Tizen platform, could we do that in more general? > At least cover Linux and Android. > > > > Thanks, > > Halton. > >> -----Original Message----- > >> From: Crosswalk-dev > >> [mailto:[email protected]] On Behalf > >> Of Xinchao He > >> Sent: Tuesday, March 10, 2015 4:47 PM > >> To: [email protected] > >> Subject: [Crosswalk-dev] Intent to Implement: Replace user agent for > >> XPK web application > >> > >> Description: > >> The Crosswalk web runtime should support to replace the user agent > >> string when a web application running on top of it, so that the > >> remote server could return the right response to the web application as > expecting. > >> > >> Affected component: Crosswalk common, Crosswalk application > >> > >> Related feature: XWALK-3689 > >> > >> Target release: Crosswalk 14 > >> > >> Implementation details: > >> > >> 1. Add a parser handler for 'xwalk_user_agent' field in XPK package > >> manifest file. > >> 2. Implement the content::ContentClient::GetUserAgent() interface in > >> XWalkContentClient. > >> 3. Move the implemented Tizen specific code > >> XWalkContentRendererClientTizen::GetOverridenUserAgent() to the > >> general place, > XWalkContentRendererClient::GetOverridenUserAgent(). > >> > >> -- > >> Best Regards, > >> He, Xinchao > >> _______________________________________________ > >> Crosswalk-dev mailing list > >> [email protected] > >> https://lists.crosswalk-project.org/mailman/listinfo/crosswalk-dev > > -- > Best Regards, > He, Xinchao _______________________________________________ Crosswalk-dev mailing list [email protected] https://lists.crosswalk-project.org/mailman/listinfo/crosswalk-dev
