Thank you very much for your comments. Yes. The things mentioned by you have hesitated me for a very long time.
I've investigated the Joone's patch for a while (and roughly talked to him my idea once), there are two difficulties to use Joone's patch here: (1) It's a Web-UI, mainly developed for Chrome Browser Web-UI has an independent cross-platform style. That's ok for Browser since Browser has a lot of opportunities to show their independent UI style. But, for middleware, most time it's an empty window to show the UI of App. In the case that must to show some own UI, taking the system standard widget may seem not so strangely. So, using the target platform's widget might be a good choice. Furthermore, consider this case, if we're using a WebUI of 'File Picker', how to deal with the existent Android-styled 'File Picker' of Crosswalk for Android? (2) It takes Wayland to involve, seems. I'm not expert of Wayland. But, by my investigation, it's a little complicated to support Wayland on Ubuntu by default (seems, there are some controversaries). And unfortunately, the target DeepIn we're working for is a variant of Ubuntu, we cannot ask them to support Wayland just for a dialog! Actually, the base design of Linux UI of Chromium is so sophisticated that we change the suit of UI widgets easily (at compiling time). If there is a KDE desktop, we can provide a suit depending on KDE, if there is new requirement from Tizen, we can provide a suit depending on the standard widgets of it. And, the Chrome, working on gnome desktop, is also using GTK2 'File Picker'. By my investigation, we're reusing the code of 'Color Picker' of Chrome on Linux, what not reuse the code of 'File Picker' too? At least, we can have 'File Picker' on Linux and not bad than Chrome. Regards, Peter Wang ------------------------------ Message: 4 Date: Mon, 16 Mar 2015 10:55:06 +0200 From: Raphael Kubo da Costa <[email protected]> To: [email protected] Subject: Re: [Crosswalk-dev] Intent to Implement: 'File Picker' of Crosswalk for Linux Message-ID: <[email protected]> Content-Type: text/plain; charset=utf-8 "Wang, Peter H" <[email protected]> writes: > Implementation details: > 1?Inherit ?ui::LinuxShellDialog? to implement the factory class of ?File > Picker? dialog. > Only ?ui::LinuxShellDialog::CreateSelectFileDialog? needs to be overridden. > 2. In ?XWalkBrowserMainParts::PreEarlyInitialization?, feed the instance of > the factory class to Content. > 3. Implement a common child class of ?ui::SelectFileDialog? and > ?aura::WindowObserver?. > Mostly, it?s referring to the code of ?select_file_dialog_impl_gtk2.cc? of > Chrome. > > Misc.: > Actually, we?ve already written a draft patch to test our design. > It only brings two new ?.cc? files and has loose couple with ?Cromium::ui? - > only need to implement some interfaces of base class. > And it?s a pretty independent module, can changed to another type of UI (e.g. > web UI) easily. Does this mean we'll start depending on GTK2 on Linux? There are some platforms (for example, Tizen) where it's not even packaged, so adding a strict dependency there would be a bad idea. I remember Joone did some work on a file picker for Ozone-Wayland [1], did you take a look at that one to see if there's anything we can use? [1] https://github.com/01org/ozone-wayland/tree/master/ui/webui ------------------------------ Subject: Digest Footer _______________________________________________ Crosswalk-dev mailing list [email protected] https://lists.crosswalk-project.org/mailman/listinfo/crosswalk-dev ------------------------------ End of Crosswalk-dev Digest, Vol 19, Issue 27 ********************************************* _______________________________________________ Crosswalk-dev mailing list [email protected] https://lists.crosswalk-project.org/mailman/listinfo/crosswalk-dev
