The Intent to Implement LGTM. Thanks, Junwei.
-----Original Message----- From: Crosswalk-dev [mailto:[email protected]] On Behalf Of Raphael Kubo da Costa Sent: Thursday, April 30, 2015 9:30 PM To: [email protected] Subject: Re: [Crosswalk-dev] Intent to Implement Ability to change application package name "Close, Rob" <[email protected]> writes: > Description: > Sometimes there is a need to change the package name of an application > at build time. This is usually done when more than one version of an > application is required. For example, a free vs a paid version of an > application. > An application package name can be changed with aapt, using the - > -rename-manifest-package parameter See this page for further > description: > http://www.piwai.info/renaming-android-manifest-package/ > > The same type of change has been made in Cordova. See these issues: > https://issues.apache.org/jira/browse/CB-5080 > https://issues.apache.org/jira/browse/CB-5481 > > Affected component: > Crosswalk Android Cordova > > Related feature: https://crosswalk-project.org/jira/browse/XWALK-3569 > > Target release: > Crosswalk-14 > > Implementation details: > The changes need to be made in XWalkViewDelegate.java Where there is > code getting a resource ID, similar to this: > resourceId = context.getResources().getIdentifier > (XWALK_RESOURCES_LIST_RES_NAME, "array", context.getPackageName()); > > The change is to first try getting the resource ID like this: > resourceId = context.getResources().getIdentifier > (XWALK_RESOURCES_LIST_RES_NAME, "array", context.getActivity > ().getClass().getPackage().getName()); > And where that returns 0, then try getting the resource ID like this: > resourceId = context.getResources().getIdentifier > (XWALK_RESOURCES_LIST_RES_NAME, "array", context.getPackageName()); It sounds reasonable to me, but I'd like to get some input from our Android folks. _______________________________________________ Crosswalk-dev mailing list [email protected] https://lists.crosswalk-project.org/mailman/listinfo/crosswalk-dev _______________________________________________ Crosswalk-dev mailing list [email protected] https://lists.crosswalk-project.org/mailman/listinfo/crosswalk-dev
