Hi Ningxin, Thanks a lot for comments~ I've re-send the intent-to-impl according required format: https://docs.google.com/a/intel.com/presentation/d/1sTkf_ITeS_n7NMLfF6iRcGy6hILZWSWP52A_4Yu0i-o/edit?usp=sharing
And addressed comments below with red texts. BR, Han Leon -----Original Message----- From: Hu, Ningxin Sent: Monday, November 16, 2015 9:24 AM To: Han, Leon; crosswalk-dev@lists.crosswalk-project.org Subject: RE: Intent-to-impl : [Android] Support Crosswalk external extensions for Cordova Android Hi Leon, Crosswalk extension is important mechanism to extend Crosswalk runtime's capability. There are no reasons that Crosswalk WebView for Android developers are not able to use them. It is also critical to enable some use cases by integrating Crosswalk extensions into Apps using Crosswalk WebView for Android. Thanks for your intent to fill the gap! First, may I suggest you upload your design doc into Google Docs? So people is able to collaborate via comments. And, it seems you missed some fields of a Crosswalk Intent to Implement declaration, e.g. target release. See "Declare your intent to implement" in https://crosswalk-project.org/contribute/contributing-code.html. My initial comments: 1. I understand this intent is mainly about filling the gap that Crosswalk WebView embedders are not able to utilize the Crosswalk external extensions. So in page 3, the "Create new cordova plugin to integrate external extensions into developers' cordova projects" seems to be extension developer's task and not in the scope of this implementation. Am I correct? (But I agree it is helpful to put the Cordova part as the use cases to help audience to understand.) [Leon] Yes this part is not in the scope of this intent-to-impl for Crosswalk. I added some explanations into design document. 2. In page 6, It would be good to give a reference to Crosswalk external extension's layout as https://crosswalk-project.org/jira/browse/XWALK-4021 does. [Leon] Added extension's layout into page6 and page7. 3. In page 10, you mentioned the impact to legacy Crosswalk external extensions (derived from XWalkExtensionClient). They will be deprecated. However, do you have any migration plans for the legacy extension users? It might be not good that the legacy extensions API will be suddenly removed. [Leon] Updated explanations in page11. Thanks, -ningxin > -----Original Message----- > From: Crosswalk-dev [mailto:crosswalk-dev-bounces@lists.crosswalk- > project.org] On Behalf Of Han, Leon > Sent: Friday, November 13, 2015 5:43 PM > To: > crosswalk-dev@lists.crosswalk-project.org<mailto:crosswalk-dev@lists.crosswalk-project.org> > Subject: Re: [Crosswalk-dev] Intent-to-impl : [Android] Support > Crosswalk external extensions for Cordova Android > > Hi, Halton, Ningxin, SunLin, > > > > Document updated as attachment. > > As this intent-to-impl is for Crosswalk Android, would you please help > to take a look? Thanks~ > > > > BR, > > Han Leon > > > > From: Crosswalk-dev [mailto:crosswalk-dev-bounces@lists.crosswalk- > project.org] On Behalf Of Han, Leon > Sent: Friday, November 13, 2015 10:58 AM > To: > crosswalk-dev@lists.crosswalk-project.org<mailto:crosswalk-dev@lists.crosswalk-project.org> > Subject: [Crosswalk-dev] Intent-to-impl : [Android] Support Crosswalk > external extensions for Cordova Android > > > > Hi, > > > > The main work will be moving external extensions framework from > xwalk_app_runtime down to xwalk_core_library, > > So that XWalk Embedding API will get the ability loading/managing > external extensions. > > > > Please review the attachment document for details. Thanks~ > > > > BR, > > Han Leon
_______________________________________________ Crosswalk-dev mailing list Crosswalk-dev@lists.crosswalk-project.org https://lists.crosswalk-project.org/mailman/listinfo/crosswalk-dev
