Hi Jenny,
Thanks for your comments~ Inline answer.
BR,
Han Leon
From: Cao, Jenny Q
Sent: Wednesday, November 18, 2015 5:55 PM
To: Han, Leon; Huo, Halton; Hu, Ningxin; Sun, Lin;
crosswalk-dev@lists.crosswalk-project.org
Subject: RE: Intent-to-impl : [Android] Support external extensions for
Crosswalk webview
Leon
I have 2 questions for Support external extensions for Crosswalk webview
1. InPage8, you mention "hide org.xwalk.core.XwalkExtension", does it
mean the internal extension API in embedding API would be deprecated and
Embedding API only support the external extension?
[Leon] Yeah I suggest to hide this class from Embedding API javadoc, while its
implementation will keep untouched in xwalk core library.
The reason to hide it:
1, Its function duplicates with
org.xwalk.core.extension.XwalkExternalExtension, both of them target to enable
developers create their own xwalk extension. Exposing both of them will confuse
developers.
2, It is hard to use for developers. Developers MUST
build own extension class based on it together with their applications. And
developers must control the extension lifecycle carefully.
2. With this feature, Embedding API would support external extension,
org.xwalk.core.XwalkExternalExtension,
While App-runtime external extension are moved to
org.xwalk.core.extension.XwalkExternalExtension, these 2 classes should provide
same capabilities, right?
What is the difference scenarios for using these 2 classes? Which one is
prefered to use when develop the extension?
[Leon] There has no XwalkExternalExtension under org.xwalk.core. In
page8 the org.xwalk.core.XWalkExternalExtension should be
org.xwalk.core.extension.XwalkExternalExtension... It is coming from
org.xwalk.app.runtime.extension.XWalkExtensionClient, to get things clear I
renamed it. Thanks a lot for point out this ;)
Thanks
Jenny
From: Crosswalk-dev [mailto:crosswalk-dev-boun...@lists.crosswalk-project.org]
On Behalf Of Han, Leon
Sent: Tuesday, November 17, 2015 4:06 PM
To: Huo, Halton; Hu, Ningxin; Sun, Lin;
crosswalk-dev@lists.crosswalk-project.org<mailto:crosswalk-dev@lists.crosswalk-project.org>
Subject: Re: [Crosswalk-dev] Intent-to-impl : [Android] Support external
extensions for Crosswalk webview
Looped Halton, Ningxin and Lin.
To external extension Developers/Users:
Please read about the following ATTENTION and if any concern about this please
feel free to let me know. Thanks.
Once this feature released in Crosswalk18,
All existing external extensions MUST alternate their base class, otherwise
they CAN'T be loaded by Crosswalk. Except this, NO other change needed.
org.xwalk.app.runtime.extension.XWalkExtensionClient -->
org.xwalk.core.extension.XWalkExternalExtension
The 2 classes provide the totally same APIs and interfaces, base class
alternation WOULD NOT bring any change to extensions impl code logic.
Description:
For Crosswalk Android, currently only Crosswalk App-runtime embedders can
utilize the external extensions management framework but Crosswalk Webview
embedders have no such capability.
I plan to move this external extensions management framework down into
Crosswalk Webview so that all kinds of Crosswalk embedders will get the same
capability loading/managing external extensions.
Affected component: Crosswalk Android, App Tools,
Cordova-Plugin-Crosswalk-WebView
Related feature: XWALK-5746 5756 5757
Target release: Crosswalk 18
Implementation details:
For design details would you please help to review the document on Google docs?
Thanks a lot~
https://docs.google.com/a/intel.com/presentation/d/1sTkf_ITeS_n7NMLfF6iRcGy6hILZWSWP52A_4Yu0i-o/edit?usp=sharing
BR,
Han Leon
-----Original Message-----
From: Crosswalk-dev [mailto:crosswalk-dev-boun...@lists.crosswalk-project.org]
On Behalf Of Han, Leon
Sent: Monday, November 16, 2015 2:35 PM
To:
crosswalk-dev@lists.crosswalk-project.org<mailto:crosswalk-dev@lists.crosswalk-project.org>
Subject: [Crosswalk-dev] Intent-to-impl : [Android] Support external extensions
for Crosswalk webview
Hi, Halton, Ningxin, SunLin,
Sorry for previous informal mail. Re-send the intent-to-impl according the
required format.
Description:
For Crosswalk Android, currently only Crosswalk App-runtime embedders can
utilize the external extensions management framework but Crosswalk Webview
embedders have no such capability.
I plan to move this external extensions management framework down into
Crosswalk Webview so that all kinds of Crosswalk embedders will get the same
capability loading/managing external extensions.
Affected component: Crosswalk Android
Related feature: XWALK-5746
Target release: Crosswalk 18
Implementation details:
For design details would you please help to review the document on Google docs?
Thanks a lot~
https://docs.google.com/a/intel.com/presentation/d/1sTkf_ITeS_n7NMLfF6iRcGy6hILZWSWP52A_4Yu0i-o/edit?usp=sharing
BR,
Han Leon
_______________________________________________
Crosswalk-dev mailing list
Crosswalk-dev@lists.crosswalk-project.org<mailto:Crosswalk-dev@lists.crosswalk-project.org>
https://lists.crosswalk-project.org/mailman/listinfo/crosswalk-dev
_______________________________________________
Crosswalk-dev mailing list
Crosswalk-dev@lists.crosswalk-project.org
https://lists.crosswalk-project.org/mailman/listinfo/crosswalk-dev
