Although already 2xLGTM, I’d like to give my LGTM. This is most comprehensive intent-to-implement I ever see.
Regards, Halton. On Jul 21, 2016, at 03:03, Kenneth Rohde Christiansen <kenneth.christian...@gmail.com<mailto:kenneth.christian...@gmail.com>> wrote: Awesome, LGTM On Mon, Jul 18, 2016, 12:43 Hu, Ningxin <ningxin...@intel.com<mailto:ningxin...@intel.com>> wrote: Description: This feature aims to allow Crosswalk app developers to leverage Node.js APIs and ecosystem to build their apps. With this feature, a Crosswalk app would be able to require a Node.js module and access its exported APIs. It supports both Node.js core modules (https://nodejs.org/api/) and npm installed modules (https://www.npmjs.com/). Further, Crosswalk app developers would also be able to package the installed Node.js modules into their app for distribution. Affected components: src/xwalk/node (NEW) src/xwalk/runtime src/xwalk/xwalk.gyp src/third_party/node (NEW) (Please find the details of affected components in the design doc). Related feature: https://crosswalk-project.org/jira/browse/XWALK-6981 Target release: Crosswalk-22/23 canary release Crosswalk-24 with Node V7 stable release (Please find the details of release cadence in the design doc) Implementation details: The design doc: https://docs.google.com/document/d/1MZgQbsM4jKfvgQuIebEyBMCeJ_CBUHWOjavyFP2WAAE/edit?usp=sharing Thanks, -ningxin _______________________________________________ Crosswalk-dev mailing list Crosswalk-dev@lists.crosswalk-project.org<mailto:Crosswalk-dev@lists.crosswalk-project.org> https://lists.crosswalk-project.org/mailman/listinfo/crosswalk-dev _______________________________________________ Crosswalk-dev mailing list Crosswalk-dev@lists.crosswalk-project.org<mailto:Crosswalk-dev@lists.crosswalk-project.org> https://lists.crosswalk-project.org/mailman/listinfo/crosswalk-dev
_______________________________________________ Crosswalk-dev mailing list Crosswalk-dev@lists.crosswalk-project.org https://lists.crosswalk-project.org/mailman/listinfo/crosswalk-dev
