Hi, The pull request got merged last week without review about SUSE support (without smoketesting, and again without much time between the pull request being opened and the merge).
I don't know enough about IPMI, to know if it's right or not, but on the other there's not much explanation on the change either... I've commented on the pull request about some weird stuff in the patch. But more importantly, I'm concerned about the fact that this seems to care about what is right for Ubuntu and RHEL, but lacks any comment about SUSE support. As far as I can tell, the old code was working fine for SUSE. And now, I'm left wondering if we want to use this or not... Cheers, Vincent Le vendredi 20 septembre 2013, à 13:09 -0700, Raajeev a écrit : > Prevent running ipmi barclamp on VMs > Prevent running unbmc.sh on VMs during admin install > Fix cosmetic issues with modprobe of ipmi_si failures on centos/redhat > > > chef/cookbooks/ipmi/providers/bmc_command.rb | 2 +- > chef/cookbooks/ipmi/providers/lan_set.rb | 2 +- > chef/cookbooks/ipmi/providers/load.rb | 10 +--------- > chef/cookbooks/ipmi/providers/unload.rb | 10 +--------- > chef/cookbooks/ipmi/providers/user_set.rb | 5 +---- > chef/cookbooks/ipmi/recipes/ipmi-discover.rb | 20 ++++++++++++++------ > 6 files changed, 19 insertions(+), 30 deletions(-) > > Crowbar-Pull-ID: 6d14733eb8ebf8e528649f2c05512e135ae91f0b > > Crowbar-Release: pebbles > You can merge this Pull Request by running: > > git pull https://github.com/Raajeev/barclamp-ipmi > pull-req-release-pebbles-master-6d14733eb8ebf8e528649f2c05512e135ae91f0b > > Or you can view, comment on it, or merge it online at: > > https://github.com/crowbar/barclamp-ipmi/pull/56 > > -- Commit Summary -- > > * Need to remove the ipmi_si module dependency - CES 21 > * Need to remove the ipmi_si module dependency - CES 21 > > -- File Changes -- > > M chef/cookbooks/ipmi/providers/bmc_command.rb (2) > M chef/cookbooks/ipmi/providers/lan_set.rb (2) > M chef/cookbooks/ipmi/providers/load.rb (10) > M chef/cookbooks/ipmi/providers/unload.rb (10) > M chef/cookbooks/ipmi/providers/user_set.rb (5) > M chef/cookbooks/ipmi/recipes/ipmi-discover.rb (20) > > -- Patch Links -- > > https://github.com/crowbar/barclamp-ipmi/pull/56.patch > https://github.com/crowbar/barclamp-ipmi/pull/56.diff -- Les gens heureux ne sont pas pressés. _______________________________________________ Crowbar mailing list [email protected] https://lists.us.dell.com/mailman/listinfo/crowbar For more information: http://crowbar.github.com/
