Updated Branches: refs/heads/master dd3ae01ae -> bd5f32c5b
CRUNCH-136: Two one line fixes: FileSourceImpl is not abstract, and WritableType's constructor is public. Project: http://git-wip-us.apache.org/repos/asf/incubator-crunch/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-crunch/commit/bd5f32c5 Tree: http://git-wip-us.apache.org/repos/asf/incubator-crunch/tree/bd5f32c5 Diff: http://git-wip-us.apache.org/repos/asf/incubator-crunch/diff/bd5f32c5 Branch: refs/heads/master Commit: bd5f32c5b89467f294423e566dbbc886e937d668 Parents: dd3ae01 Author: Josh Wills <[email protected]> Authored: Tue Dec 18 11:36:20 2012 -0800 Committer: Josh Wills <[email protected]> Committed: Tue Dec 18 11:49:54 2012 -0800 ---------------------------------------------------------------------- .../org/apache/crunch/io/impl/FileSourceImpl.java | 2 +- .../apache/crunch/types/writable/WritableType.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-crunch/blob/bd5f32c5/crunch/src/main/java/org/apache/crunch/io/impl/FileSourceImpl.java ---------------------------------------------------------------------- diff --git a/crunch/src/main/java/org/apache/crunch/io/impl/FileSourceImpl.java b/crunch/src/main/java/org/apache/crunch/io/impl/FileSourceImpl.java index 4038b60..e67845a 100644 --- a/crunch/src/main/java/org/apache/crunch/io/impl/FileSourceImpl.java +++ b/crunch/src/main/java/org/apache/crunch/io/impl/FileSourceImpl.java @@ -33,7 +33,7 @@ import org.apache.hadoop.mapreduce.InputFormat; import org.apache.hadoop.mapreduce.Job; import org.apache.hadoop.mapreduce.lib.input.FileInputFormat; -public abstract class FileSourceImpl<T> implements Source<T> { +public class FileSourceImpl<T> implements Source<T> { private static final Log LOG = LogFactory.getLog(FileSourceImpl.class); http://git-wip-us.apache.org/repos/asf/incubator-crunch/blob/bd5f32c5/crunch/src/main/java/org/apache/crunch/types/writable/WritableType.java ---------------------------------------------------------------------- diff --git a/crunch/src/main/java/org/apache/crunch/types/writable/WritableType.java b/crunch/src/main/java/org/apache/crunch/types/writable/WritableType.java index 93b0518..fd64b3a 100644 --- a/crunch/src/main/java/org/apache/crunch/types/writable/WritableType.java +++ b/crunch/src/main/java/org/apache/crunch/types/writable/WritableType.java @@ -44,7 +44,7 @@ public class WritableType<T, W extends Writable> implements PType<T> { private final List<PType> subTypes; private boolean initialized = false; - WritableType(Class<T> typeClass, Class<W> writableClass, MapFn<W, T> inputDoFn, + public WritableType(Class<T> typeClass, Class<W> writableClass, MapFn<W, T> inputDoFn, MapFn<T, W> outputDoFn, PType... subTypes) { this.typeClass = typeClass; this.writableClass = writableClass;
