+1 for a style guide and/or formatting rules and coding rules. For code style, something that I've seen work well (at least if everyone is using Eclipse) is to just have a shared code style definition that you can import into Eclipse, and then set Eclipse to apply that style whenever you save a file. This works great if everyone uses the same style definition, and breaks down rapidly if they don't.
I don't have any experience using the maven-findbugs-plugin, but I do find the Checkstyle useful, as long as the settings are sane (which is not always the case). On Saturday 16 June 2012 at 00:17, Josh Wills wrote: > I'm in favor of a style guide; consistent layout makes it easier for > my brain to devour code. That said, I'm not up-to-date on best > practices here in the real world; my only experience with automated > code review tools was at teh goog. > > Re: code reviews, let's start that discussion up in another thread. > > J > > On Fri, Jun 15, 2012 at 3:13 PM, Robert Chu <[email protected] > (mailto:[email protected])> wrote: > > Hey Everybody, > > > > I'd like to start a discussion about using automated code review tools > > to improve the crunch development process. I'd I'm personally a big > > fan of using tools that can help improve code quality. These tools > > often include things like the maven-checkstyle-plugin and the maven- > > findbugs-plugin. I am currently unaware of any comparable scala > > automated tools. If people have opinions on whether or not we should > > use tools like this or which tools we should be using specifically > > please let us know. > > > > Also, another related question: Should we have some sort of a code > > review process? > > > > Robert Chu > > > > -- > Director of Data Science > Cloudera > Twitter: @josh_wills
