[
https://issues.apache.org/jira/browse/CRUNCH-26?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13424019#comment-13424019
]
Matthias Friedrich commented on CRUNCH-26:
------------------------------------------
Looks good, I just noticed one issue: You had to depend on Crunch's test-jar to
be able to use TemporaryPath. The downside is that this breaks "mvn install
-Dmaven.test.skip=true" unless you can get the test-jar from some repository. I
see two options here: a) don't use TemporaryPath, instead implement something
in Scala that fits better, or b) create a new module crunch-test where we put
TemporaryPath and other testing helpers that we or our users might need.
If you decide for b) I wouldn't mind doing it.
> Make Scrunch tests suitable for continuous integration
> ------------------------------------------------------
>
> Key: CRUNCH-26
> URL: https://issues.apache.org/jira/browse/CRUNCH-26
> Project: Crunch
> Issue Type: Task
> Components: Scrunch
> Affects Versions: 0.3.0
> Reporter: Josh Wills
> Assignee: Josh Wills
> Attachments: CRUNCH-26.patch
>
>
> The scrunch equivalent of the changes done to Crunch in CRUNCH-24.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
