[ 
https://issues.apache.org/jira/browse/CRUNCH-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428993#comment-13428993
 ] 

Rahul Sharma commented on CRUNCH-23:
------------------------------------

Josh, I don't know how can you test this in build. I tested the solution by 
running attached SortTest on a cluster.

The solution would fail a job if there is a single node and we try to run it on 
multiple reducers by looking at the bytes.per.reduce.task. In such a case it 
throws back exception saying :

Caused by: java.io.IOException: Wrong number of partitions in keyset
    at 
org.apache.hadoop.mapreduce.lib.partition.TotalOrderPartitioner.setConf(TotalOrderPartitioner.java:82)
    ... 6 more 

Also there is code that we can get into MRPipeline like creation of sample. I 
can do some improvements on that side. 
                
> PCollection#sort doesn't do a full sort on values
> -------------------------------------------------
>
>                 Key: CRUNCH-23
>                 URL: https://issues.apache.org/jira/browse/CRUNCH-23
>             Project: Crunch
>          Issue Type: Bug
>            Reporter: Gabriel Reid
>            Assignee: Rahul Sharma
>         Attachments: 0001-CRUNCH-23-fix-sorting.patch, 
> CRUNCH-23-used-TotalOrderpartioner-for-sorting-keys.patch, SortTest.java
>
>
> When a PCollection is sorted (using PCollection#sort), the sorting that is 
> performed is only per reducer, and not an absolute sort over all values. This 
> means that the values are not in sorted order if they are iterated over on a 
> materialized collection. It also means that the sorted files that are output 
> from a sort operation can not be simply concatenated to come to a single 
> sorted file.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to