[ 
https://issues.apache.org/jira/browse/CRUNCH-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13467644#comment-13467644
 ] 

Matthias Friedrich commented on CRUNCH-75:
------------------------------------------

Two things I noticed at first glance: You'll have to add crunch-contrib as a 
dependency of crunch-dest, otherwise it won't be part of the binary release 
(see CRUNCH-76). Second thing: Could you create the patch via 
--find-copies-harder, that'll make it much shorter and easier to read.
                
> Have a method to create Bloom filters in Crunch
> -----------------------------------------------
>
>                 Key: CRUNCH-75
>                 URL: https://issues.apache.org/jira/browse/CRUNCH-75
>             Project: Crunch
>          Issue Type: New Feature
>            Reporter: Rahul Sharma
>            Assignee: Rahul Sharma
>         Attachments: 
> 0002-Created-crunch-bytes-module-for-users-to-share-funct.patch, 
> 0002-CRUNCH-75-Added-BloomFilters-to-crunch-contrib.patch
>
>
> As per discussion on mailing list, Bloomfilters provide interesting addon to 
> crunch. But the crunch-core is not the correct place to add such a thing. So 
> create a module i.e. something along the lines on  piggybank of Pig. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to