[
https://issues.apache.org/jira/browse/CRUNCH-115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13500208#comment-13500208
]
Tom White commented on CRUNCH-115:
----------------------------------
This change looks good to me. I had a couple of follow on comments:
* Listing the version numbers of libraries in the LICENSE file is not necessary
and will make future library updates more error prone (since there will be two
places to change the version numbers).
* Projects don't usually ship test artifacts, so why are JUnit and Mockito in
the binary distibution at all? Is this an oversight or are they needed by the
main code?
> The binary distribution must include licenses of dependencies
> -------------------------------------------------------------
>
> Key: CRUNCH-115
> URL: https://issues.apache.org/jira/browse/CRUNCH-115
> Project: Crunch
> Issue Type: Bug
> Affects Versions: 0.4.0
> Reporter: Matthias Friedrich
> Assignee: Matthias Friedrich
> Fix For: 0.5.0
>
> Attachments: CRUNCH-115-Fix-licensing-issues.patch,
> CRUNCH-115-Fix-licensing-issues-v2.patch,
> CRUNCH-115-Fix-licensing-issues-v3.patch
>
>
> Our binary distribution contains libraries distributed under various
> licenses. We have to include these licenses in our LICENSE and NOTICE files,
> where necessary.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
