Hi devs,

I'm looking at the static factory methods on the From class, which produce
Source or TableSource objects to form input to a Crunch job.

Couple of questions:
- Is there a reason why there are only TableSource versions of the
formattedFile methods which can take a custom input format? I'd find a
Source version of these which ignore the key quite useful. (I've already
knocked up a quick patch, but I just wanted to sound you out before I went
ahead and tidied it up properly or created a JIRA for it.)

- How come FileSourceImpl is abstract but FileTableSourceImpl is not? In my
patch mentioned above, I've had to remove abstract from FileSourceImpl, so
I'm keen to know if that would break anything.

Cheers,
Dave

Reply via email to