DEA-1 usr/src/uts/common/Makefile.files
The only change here I see is deleting a blank line, which doesn't seem
worth it. Was the file touched accidentally or were changes made earlier and
undone?
DEA-2 usr/src/common/crypto/padding/pkcs1, functions pkcs1_encode() and
pkcs1_decode()
87 CKR_DEVICE_ERROR : 0;
107 return (0);
144 return (0);
I think this should return CKR_OK rather than 0--it's more clear, especially
since you return CKR_* error codes elsewhere in the same function.
Or if you don't want to do that, could you document the fact that 0 is OK in
the function header?
- Dan
--
This message posted from opensolaris.org
