Ditto everything Dan said, except you can use my name instead of his as
a reviewer as well. :-)
-- Garrett
Dan McDonald wrote:
> On Tue, Sep 30, 2008 at 11:20:24AM -0700, Dan Anderson wrote:
> <SNIP!>
>
>> http://sw.west/~da73024/reviews/onnv/6750027-xopen/
>>
>
>
>> I forgot to use _XPG4_2 guards around ntohll()/htonll(), which are not
>> POSIX/XOPEN-allowed symbols.
>>
>
> XOpen != POSIX, if I recall correctly, but I get the idea. (This is an
> X/Open problem.)
>
>
>> I also added code to not use uint64_t when it's not defined (using the same
>> _LP64 and _LONGLONG_TYPE guards as used to define uint64_t in
>> sys/inttypes.h).
>>
>
> Good call!
>
>
>> The header file now passes the UNIX Standards header tests, according to
>> Michael Light, who filed the bug.
>>
>
> Doubly good call! I would've suggested someone else, but Michael works in
> the same group, and therefore is a reliable source for this arcana.
>
> The changes look good to me. Please run nightlies to make sure no new
> oddness shows up, and then count me as a reviewer.
>
> Dan
> _______________________________________________
> crypto-discuss mailing list
> crypto-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/crypto-discuss
>
