The changes to fix my previous concerns look OK (the struct rndmag_s size calculation and unneeded casting).
DEA-3: kcf_random.c I noticed one other thing is the rm_counter in struct rndmag_s is no longer used. If this is true, please remove field rm_counter on line 600 and remove mention of a "rotating counter" from the comment on line 618. Similarly, field rm_ks and rm_stats are also unused. If these unused fields have to be present for some backwards compatibility or standard, then please ignore this remark. DEA-4: fips_random.h You added BYTES_IN_WORD in the latest update to the webrev: 38 #define SHA1BYTES (4 * SHA1WORDS) 39 #define BYTES_IN_WORD 4 This could be changed to this: #define BYTES_IN_WORD 4 #define SHA1BYTES (BYTES_IN_WORD * SHA1WORDS) -- This message posted from opensolaris.org
