Since get_ulong_attr_from_template() is not declared in a header and is not used in another source file, it should be static:
853 CK_RV 854 get_ulong_attr_from_template(CK_ULONG *value, CK_ATTRIBUTE_PTR template) Change line 853 to: 853 static CK_RV Otherwise, LGTM. -- This message posted from opensolaris.org
