No problem, how's this? (Please ignore my FIXME comment in patch 5. I forgot to trim that out. It's a hold-over from when I was first learning the code. I'm biased towards having pairs of resource acquisition and release functions be named such that they're obvious pairs... but since I'm not prepared to offer a patch set to suggest any changes along those lines, I should've left it out.)
I'm currently using memalign in my test app. I'm sure I've previously used alloc and/or that it would work fine. I've just been focused on integration & debugging and haven't patched the speed tests yet. - Jaren -----Original Message----- From: Nikos Mavrogiannopoulos [mailto:n.mavrogiannopou...@gmail.com] On Behalf Of Nikos Mavrogiannopoulos Sent: Sunday, June 10, 2012 1:30 AM To: Jaren Johnston Cc: cryptodev-linux-devel@gna.org Subject: Re: [Cryptodev-linux-devel] patches to allow PT == AAD == 0 On 06/09/2012 10:42 PM, Jaren Johnston wrote: > Hey there, > I've recently been working on some GCM cases with empty PT and AAD. I > don't know how useful they are in practice, but they're legit and show > up in validation tests (e.g., FIPS). Hello, Indeed it is a useful addition. However you sent the patches in html mail and it not easy to get them out. I think it is simpler to send them as text attachments, and it is nice if you send multiple patches to put the patch number in the subject. > * I ran all the functional tests, not just cipher-gcm. I've not done > the speed tests yet -- still need to swap out the posix_memaligns for Android. Did you try normal malloc instead of memalign? regards, Nikos
cryptodev-patch-sets.tar.gz
Description: Binary data
_______________________________________________ Cryptodev-linux-devel mailing list Cryptodev-linux-devel@gna.org https://mail.gna.org/listinfo/cryptodev-linux-devel
