Hi Christian, On Tue, Jan 21, 2014 at 08:26:35AM +0000, cristian.sto...@freescale.com wrote: > Hi Phil, > > > Wouldn't it be better to conditionally define INIT_COMPLETION to > > reinit_completion for newer kernels? Doesn't this break downwards > > compatibility? > > > > I could think of something like: > > > > #if (LINUX_VERSION_CODE >= KERNEL_VERSION(3, 12, 0)) > > # define INIT_COMPLETION(x) reinit_completion(%(x)) > > #endif > > > Do you have any comments on the v2 of the patch? > https://mail.gna.org/public/cryptodev-linux-devel/2014-01/msg00004.html
Looking good so far. I just compile-tested against 3.10 and 3.13 without problems. If you don't mind, I'll leave the patch sitting for a few more days to allow for more discussion (if any at all). Greetings, Phil _______________________________________________ Cryptodev-linux-devel mailing list Cryptodev-linux-devel@gna.org https://mail.gna.org/listinfo/cryptodev-linux-devel