Hi,

On Mon, Jun 23, 2014 at 06:57:25PM +0300, Cristian Stoica wrote:
> - destination length is rounded to multiple of blockcipher length
>   before encryption

This means we write more data into the userspace-supplied buffer than
requested without noticing it. Although this might be correct in regards
of the cipher mode's requirements, we could corrupt userspace memory by
doing so. Correctly calculating the needed bufferspace for the requested
operation is something I consider to be the caller's job, cryptodev
should rather deny the operation instead of silently fixing it. Or what
do you think?

Best wishes, Phil

_______________________________________________
Cryptodev-linux-devel mailing list
Cryptodev-linux-devel@gna.org
https://mail.gna.org/listinfo/cryptodev-linux-devel

Reply via email to