Hi Phil, On Fri, Aug 05, 2016 at 01:13:44PM +0200, Michael Weiser wrote:
> > If you care to provide a patch, I'd happily test/review it. > I'll give it a whirl and report back. I've done some groundwork, mostly research through a well known search engine and in the kernel code. What I've found is now at https://github.com/michaelweiser/cryptodev-linux/commit/30e66ed072d34ad0ca93f7457a9772519ca68de0. It compiles but I haven't had a chance to actually test it for function yet. It turns out skcipher is fairly young: It entered mainline with 4.3. What is your take on supporting old kernel versions: Should I #ifdef for < 4.3 or can I just drop ablkcipher like I've done now? BTW: I've looked into https://github.com/cryptodev-linux/cryptodev-linux/issues/12 more closely to get cryptodev-linux to compile against current master. Moonman's proposed fix (https://github.com/cryptodev-linux/cryptodev-linux/pull/13/commits/cdbe7ee5978704c788e91170467fe0db064650fe) seemed too good to be true to me. I came up with https://github.com/michaelweiser/cryptodev-linux/commit/70f3aff97fc44079afcb2cc058c37bba320c5a57. Does that look sensible to you? -- bye, Michael _______________________________________________ Cryptodev-linux-devel mailing list Cryptodev-linux-devel@gna.org https://mail.gna.org/listinfo/cryptodev-linux-devel
