Hi Erik, Thank you for your contribution! Some of your work overlaps with the interfaces we're currently building (https://github.com/pyca/cryptography/pull/1906/), but there is implementation work and other interfaces that will be very useful. Incidentally, your approach to fullname/relativename is one of the discussions underway on that PR right now.
The normal way we do contribution and code review is via pull requests on GitHub. You can put your initial work up for discussion by doing the following: * Fork the project to your own account on github and check it out * Branch, commit, and push the branch to your own repository * Open a pull request against pyca/cryptography by following these instructions (https://help.github.com/articles/creating-a-pull-request/) We're also available on freenode in #cryptography-dev to chat any time. I personally would say this work should probably wait on merging #1906, at which point we can pull in the CRLDistributionPoints OpenSSL implementation, then follow that up with a PR for the CRL object, and finally the OpenSSL implementation of a parser to build the CRL object. -Paul On May 7, 2015 at 12:01:15 PM, Erik Trauschke (erik.trausc...@gmail.com) wrote: Hi all, For my project I need cryptography to support basic handling of CRLs, revoked certificates and CRLDistributionPoints. I attached a patch which adds these interfaces, including test cases for it. I have never provided patches to a github project so I'm not sure how the process works. Do you have a separate place for code reviews (I haven't seen code review discussions on this list)? I would appreciate if someone could look at my changes and put them back to the gate, but let me know if I need to approach this differently. Thanks Erik _______________________________________________ Cryptography-dev mailing list Cryptography-dev@python.org https://mail.python.org/mailman/listinfo/cryptography-dev
_______________________________________________ Cryptography-dev mailing list Cryptography-dev@python.org https://mail.python.org/mailman/listinfo/cryptography-dev
