On Wednesday, July 10, 2013 9:26:49 PM UTC-4, Jeff Waller wrote:
>
> Few things.
>
> The detection for clang is not correct as it operates on OS X 10.7 and
> XCode 4.6.2
>
> This does not work
>
> CLANG_COMPILER = $(shell $(CXX) --version 2>&1 | $(EGREP) -i -c "clang
> version")
>
> This does
>
> CLANG_COMPILER = $(shell $(CXX) --version 2>&1 | $(EGREP) -i -c "LLVM
> version")
>
Yeah, Wei's got a patch for that. "LLVM version" breaks some older Apple
Clang installations, so its easier just to check for "^clang" or "clang".
>
> Further there a a couple of warnings that clang emits that can be
> corrected with the
> following.
>
> ifneq ($(CLANG_COMPILER),0)
> CXXFLAGS += -Wno-tautological-compare -Wno-unused-value
> endif
>
> With those 2 switches in the library compiles cleanly except for 2 warnings
> that you might want to look into, the last one looks like a genuine error.
>
> c++ -DNDEBUG -g -O2 -DCRYPTOPP_DISABLE_ASM -pipe -Wno-tautological-compare
> -Wno-unused-value -c asn.cpp
> asn.cpp:312:11: warning: enumeration values 'TAIL' and 'ALL_DONE' not
> handled in switch [-Wswitch]
> switch (m_state)
>
This is legal per the C/C++ standard. Neither 'TAIL' and 'ALL_DONE' are
handled; nor is the default case, so execution never enters the switch.
c++ -DNDEBUG -g -O2 -DCRYPTOPP_DISABLE_ASM -pipe -Wno-tautological-compare
> -Wno-unused-value -c wait.cpp
> wait.cpp:366:62: warning: adding 'int' to a string does not append to the
> string [-Wstring-plus-int]
> throw Err("WaitObjectContainer: select failed with error "
> + errno);
>
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~
> wait.cpp:366:62: note: use array indexing to silence this warning
> throw Err("WaitObjectContainer: select failed with error "
> + errno);
>
This is an error and Wei has a patch for it.
Jeff
--
--
You received this message because you are subscribed to the "Crypto++ Users"
Google Group.
To unsubscribe, send an email to [email protected].
More information about Crypto++ and this group is available at
http://www.cryptopp.com.
---
You received this message because you are subscribed to the Google Groups
"Crypto++ Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
