Am 01.07.2015 um 06:17 schrieb Jeffrey Walton: > Is anyone opposed to removing some unneeded sources from the makefile? > The files will still be present on-disk - they will just be removed > from the makefile's recipes. > > Are there other files that can be removed? We definitely need a Cygwin expert on this list...
For me it's ok, it won't break anything with Visual Studio so I'm happy. Looks like we indeed don't /need/ dlltest.cpp assuming the code starting at line 174 <https://github.com/weidai11/cryptopp/blob/master/dlltest.cpp> isn't needed for anything other than testing. Cryptlib_bds.cpp can indeed be removed as it actually does /nothing/. Although it doesn't like pch.cpp does anything it actually provides pre-compiled headers to the other source-files, speeding up the build in VS. However it doesn't look like this functionality is used in the makefile, so it can safely be excluded. Personally I'd prefer winpipes.cpp to stay, as it actually implements the logic of winpipes.h, if somebody builds from the makefile using cygwin, I think he may need these functions / classes and as per config.h file (if I'm reading things right) these functions will indeed be available in the header. BR JPM > > ********** > > $ git diff GNUmakefile > diff --git a/GNUmakefile b/GNUmakefile > index 3defa68..885a0e1 100644 > --- a/GNUmakefile > +++ b/GNUmakefile > @@ -139,6 +139,9 @@ ifeq ($(SRCS),) # > workaround wil > SRCS = $(shell echo *.cpp) > endif > > +UNNEEDED = cryptlib_bds.cpp dlltest.cpp pch.cpp winpipes.cpp > +SRCS := $(filter-out $(UNNEEDED),$(SRCS)) > + > OBJS = $(SRCS:.cpp=.o) > # test.o needs to be after bench.o for cygwin 1.1.4 (possible ld bug?) > TESTOBJS = bench.o bench2.o test.o validat1.o validat2.o validat3.o > adhoc.o dat > > -- > -- > You received this message because you are subscribed to the "Crypto++ > Users" Google Group. > To unsubscribe, send an email to > [email protected]. > More information about Crypto++ and this group is available at > http://www.cryptopp.com. > --- > You received this message because you are subscribed to the Google > Groups "Crypto++ Users" group. > To unsubscribe from this group and stop receiving emails from it, send > an email to [email protected] > <mailto:[email protected]>. > For more options, visit https://groups.google.com/d/optout. -- -- You received this message because you are subscribed to the "Crypto++ Users" Google Group. To unsubscribe, send an email to [email protected]. More information about Crypto++ and this group is available at http://www.cryptopp.com. --- You received this message because you are subscribed to the Google Groups "Crypto++ Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
smime.p7s
Description: S/MIME Cryptographic Signature
