Am 08.07.2015 um 21:44 schrieb Jeffrey Walton: > Hi Everyone, > > Git commit got away from me. I was trying to commit GNUmakefile > changes for -O3, but I forgot to use a file with `git commit <file> -m > <message>`. So I did a reset according to > http://stackoverflow.com/q/101752, and then re-performed the commit > with the filename. Finally, I pushed the change. > > Then, on another machine, I tested with: > > $ git pull > Updating 8393eeb..94f2809 > Fast-forward > GNUmakefile | 28 ++++++++++++++------ > cryptlib.h | 23 +++++++++++++++- > hkdf.h | 87 > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 129 insertions(+), 9 deletions(-) > create mode 100644 hkdf.h > > It looks like HKDF went in too soon. It went in too soon because we > are still discussing the design. The implementation is technically > correct. > > QUESTION: should I revert the change to remove HKDF, or should I > commit the validation suite for HKDF? I think this fully depends on you:
* If it is easier for you to remove HKDF and input it all at once (as
soon as we've settled on a design), go for it
* If it is easier for you to let it there and update it later, maybe
add a note that HKDF interface is subject to change very soon and
leave it (+ commit the validation).
You can do it as you want, although we may actually want to make two
branches on GitHub ("latest stable" = 5.6.2 and "development"=current
status), so if we have such "errors" on development nothing will be
wrong and we can mess however we want :)
BR
JPM
>
> The parallel, SVN commit was fine:
> https://sourceforge.net/p/cryptopp/code/574/.
>
> Sorry about the mixup.
>
> Jeff
>
> On Friday, July 3, 2015 at 5:17:15 AM UTC-4, Jeffrey Walton wrote:
>
> I'd like to add the following to the library. It provides Krawczyk
> and Eronen's HKDF.
>
> The patch has a few more changes, like the addition of COUNTOF to
> validat3.cpp, but don't focus on them.
>
> Any comments or objections?
>
> --
> --
> You received this message because you are subscribed to the "Crypto++
> Users" Google Group.
> To unsubscribe, send an email to
> [email protected].
> More information about Crypto++ and this group is available at
> http://www.cryptopp.com.
> ---
> You received this message because you are subscribed to the Google
> Groups "Crypto++ Users" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to [email protected]
> <mailto:[email protected]>.
> For more options, visit https://groups.google.com/d/optout.
--
--
You received this message because you are subscribed to the "Crypto++ Users"
Google Group.
To unsubscribe, send an email to [email protected].
More information about Crypto++ and this group is available at
http://www.cryptopp.com.
---
You received this message because you are subscribed to the Google Groups
"Crypto++ Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
smime.p7s
Description: S/MIME Cryptographic Signature
