Hi Robert, On Tue, Jul 14, 2015 at 4:42 PM, Robert Roessler <[email protected]> wrote: > First off, it is likely improper to address you directly... but as a member > of the previous Crypto++ mailing list, I am unclear exactly how to post > these days - would replying or just directly addressing > [email protected] just work? :)
No problem, swinging it back to Crypto++ Users. > Other than that, I have some time, and have been watching the the traffic > for the last weeks - *someone* sure has a lot of energy! ;) Yeah, I'm in between contracts, so I've been trying to clear as many issues as possible :) > But I think on this warning - which just started bugging me after I synced > my WC yesterday after a lengthy gap - you were faked out like I was... OK, the additional warnings on Visual Studio likely came because of https://github.com/weidai11/cryptopp/commit/e67480dd9e8dcda57939fc7480e273b8d2e81335. We also cleared some more misc.h warnings at https://github.com/weidai11/cryptopp/commit/828c550389f79b035f4518a79b7138d281f0961c. > believe the actual complaint from VS (2013 for me) is caused by the various > low-level workhorse "rotate" functions declaring their "shift" param as an > unsigned char - which is where the actual alleged truncation is taking place > (or would). Here's the commit/comment on the truncation to char: https://github.com/weidai11/cryptopp/commit/457eaeaf2317faa30c86d6d3fc289f40c58cf177. It added assert(y <= 255), which turned out to be spurious because of assert(y <= sizeof(T)*8). The latter was really assert(y <= 32). But I'm having trouble parsing what the problem is, or what you want me to do. Where do you see a problem, or what do you suggest we do? Jeff -- -- You received this message because you are subscribed to the "Crypto++ Users" Google Group. To unsubscribe, send an email to [email protected]. More information about Crypto++ and this group is available at http://www.cryptopp.com. --- You received this message because you are subscribed to the Google Groups "Crypto++ Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
