On Tuesday, July 14, 2015 at 8:11:53 PM UTC-4, Robert Roessler wrote: > > Jeffrey Walton wrote: > > On Tue, Jul 14, 2015 at 6:20 PM, Robert Roessler wrote: > >> Jeffrey Walton wrote: > >>> > >>> ... > >>> OK, the additional warnings on Visual Studio likely came because of > >>> > >>> > https://github.com/weidai11/cryptopp/commit/e67480dd9e8dcda57939fc7480e273b8d2e81335 > . > >>> > >>> We also cleared some more misc.h warnings at > >>> > >>> > https://github.com/weidai11/cryptopp/commit/828c550389f79b035f4518a79b7138d281f0961c > . > >>> > >>>> believe the actual complaint from VS (2013 for me) is caused by the > >>>> various > >>>> low-level workhorse "rotate" functions declaring their "shift" param > as > >>>> an > >>>> unsigned char - which is where the actual alleged truncation is taking > >>>> place > >>>> (or would). >
I have not forgot about this. I'm untangling the difference between rotrFixed, rotrVariable and rotrMod (and friends). The next check-in will have definitions or expected behaviors for them. Once everyone knows what should be happening, then we can tackle policy decisions, like "do we assert for external library callers". Jeff -- -- You received this message because you are subscribed to the "Crypto++ Users" Google Group. To unsubscribe, send an email to [email protected]. More information about Crypto++ and this group is available at http://www.cryptopp.com. --- You received this message because you are subscribed to the Google Groups "Crypto++ Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
