> I just noticed that commit 48809d4e85c125814425c621d8d0d89f95405924 
>> (CRYPTOPP 5.6.3 RC6 checkin) has changed encoding of most if not all files 
>> to DOS. 
>>
>> Was this intentional? 
>>
>
> Yes. Crypto++ has always been DOS/Windows based. From the homepage (
> https://www.cryptopp.com/):
>
>     Remember to use the "-a" (auto-convert text files)
>     option when unzipping on a Unix machine.
>
> Over the years, so much stuff has been added in so many formats it kind of 
> got lost. Additionally, Visual Studio is very tolerant, so the 
> cross-pollination kind of went undetected.
>
> As a matter of policy and procedure, we try to run 'unix2dos' over plain 
> text files before a check-in to ensure they are consistent. We also run 
> 'dos2unix' over the scripts, like cryptest.sh, because they are used on 
> Unix and Linux machines.
>
> To help with consistent results, the Makefile now includes a 'make 
> convert' recipe: 
> https://github.com/weidai11/cryptopp/blob/master/GNUmakefile#L423 .
>
>
> Jeff, thanks for the explanation.
>
> The main reason I went digging is because the recently updated cryptopp 
> package for HomeBrew (OSX) now includes headers in dos encoding.  I would 
> suspect that not everybody is aware of the change, given that the encoding, 
> at least in git repo, was different before.  Not a big deal, really.
>
> Should we consider using .gitattributes (
> http://git-scm.com/docs/gitattributes)?  Though I have no much experience 
> with it.
>

That may be a good idea. Here's my first pass on it...

  (1) CRLF in the Remote
  (2) Conversion occurs at cone/checkout

 Two questions....

  (3) Is it possible to configure it based on platform?
        - Windows applies CRLF
        - Unix/Linux applies LF
        - OS X applies CR

Or:

  (2) is it possible to set it to auto?
        - Git does the right thing without platform specific callouts

Can anyone comment on it?

-----

My only two requirements are:

  (A) perform the following before check-in:

      make convert

  (B) perform the following to build the ZIP:

      make zip     # performs 'make convert'

-- 
-- 
You received this message because you are subscribed to the "Crypto++ Users" 
Google Group.
To unsubscribe, send an email to cryptopp-users-unsubscr...@googlegroups.com.
More information about Crypto++ and this group is available at 
http://www.cryptopp.com.
--- 
You received this message because you are subscribed to the Google Groups 
"Crypto++ Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to cryptopp-users+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to