On Wednesday, September 28, 2016 at 6:28:50 AM UTC-4, Andrew Marlow wrote: > > Hello everyone, > > I am trying to tighten up my project code by enabling more compiler > warnings and using the flag that says to treat warnings as errors. > Unfortunately this causes an error in that part of the project that uses > cryptopp version 563. The warning I get is: > > <directoryName>ThirdPartyLibs/cryptopp563/misc.h:1074: error: std::string > CryptoPP::StringNarrow(const wchar_t*, bool) defined but not used > > I am on RHEL 6.8 using gcc 4.4.8. > > Could this issue be cleaned up in the next version to be released please? >
I seem to recall the biggest concern about StringNarrow was it was marked static and header-only, so it could possibly violate the One Definition Rule. It looks like we fixed it in Crypto++ 5.6.4 at http://github.com/weidai11/cryptopp/commit/a0390f1fd725e37a201cc47ba47204182ebc1ccf . Maybe you could backport the fix? Since you are not using the function, another option for your project is to delete it in its entirety. You will be safe doing it because its only used in files.cpp. files.cpp is already compiled into object code by the time you get around to using the library, so a missing function won't affect library source files or object code. Jeff -- -- You received this message because you are subscribed to the "Crypto++ Users" Google Group. To unsubscribe, send an email to [email protected]. More information about Crypto++ and this group is available at http://www.cryptopp.com. --- You received this message because you are subscribed to the Google Groups "Crypto++ Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
