On Sunday, March 26, 2017 at 11:16:43 PM UTC-4, Michael Shiels wrote: > > > On Sunday, March 26, 2017 at 11:00:09 PM UTC-4, Michael Shiels wrote: >> >> From debugging it seems the calling convention or something is off >> between the C/C++ side and the MASM PROC side - it's running way over the >> end of the buffer. >> >> I am using a prior build 5.6.2 without and problems so not sure what's up >> with this particular build. I assume VS2010 is still supported?? >> > > And I think I resolved that - was quite easy - allow the asembler > prologue/epilogue to be generated - since it's needed to access the > parameters correctly. > > .CODE > ALIGN 8 > OPTION LANGUAGE:C > ;;OPTION PROLOGUE:NONE > ;;OPTION EPILOGUE:NONE > > AND Kaboom it works!!! So I guess no one is running the crypttest on > Win32??? >
Yeah, Win32 slips between the cracks on occasion. I usually get to it when I rotate into testing on a Lenovo netbook with an Atom processor. >From a policies and procedures point of view, we need a torture test for the platform like we have for Unix and Linux. There's an open bug report at https://github.com/weidai11/cryptopp/issues/159. Its on my TODO list. As far as RDRAND issues, grab the latest sources in Master. You need rdrand.h, rdrand.cpp and rdrand.asm. We switched to fastcall to completely avoid prologues and epilogues. We are also using ecx/rcx and edx/rdx since they don't need preserving (and that's where fastcall places its first two args). RDRAND and RDSEED under went a few other changes, like forgoing the accounting on retires. We found we got better rates out of both generators by retrying a failed operation immediately. Also see https://groups.google.com/d/msg/cryptopp-users/a3lbZHfFgkA/Da__nVSgEgAJ, where we detail some of the design and performance problems with the original classes. You can get the latest files by following the links below. * https://raw.githubusercontent.com/weidai11/cryptopp/master/rdrand.h * https://raw.githubusercontent.com/weidai11/cryptopp/master/rdrand.cpp * https://raw.githubusercontent.com/weidai11/cryptopp/master/rdrand.asm I think the wiki has some old RDRAND files. I'm guessing that's where you are getting the files for 5.6.2. I need to get those downloads updated. I'll do that shortly. Jeff -- -- You received this message because you are subscribed to the "Crypto++ Users" Google Group. To unsubscribe, send an email to cryptopp-users-unsubscr...@googlegroups.com. More information about Crypto++ and this group is available at http://www.cryptopp.com. --- You received this message because you are subscribed to the Google Groups "Crypto++ Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to cryptopp-users+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.