Hi Everyone,

We have a PR for "Use ::byte instead of byte", 
https://github.com/weidai11/cryptopp/pull/438/files.

The background is C++17 is adding std::byte, and its causing some compile 
issues for folks with GCC 7 and above. The issue is due to 
(https://github.com/weidai11/cryptopp/blob/master/config.h#L197):

    // put in global namespace to avoid ambiguity with other byte typedefs
    typedef unsigned char byte;

I think we have a few options, but its not clear to me which is the best at 
the moment. One of them includes:

    #if CRYPTOPP_CXX17
        typedef std::byte byte;
    #else
        // put in global namespace to avoid ambiguity with other byte 
typedefs
        typedef unsigned char byte;
    #endif

Or maybe even:

    #if CRYPTOPP_CXX17
        using byte = std::byte;
    #else
       ...

If you have any comments, please add them to the PR.

Jeff

-- 
-- 
You received this message because you are subscribed to the "Crypto++ Users" 
Google Group.
To unsubscribe, send an email to cryptopp-users-unsubscr...@googlegroups.com.
More information about Crypto++ and this group is available at 
http://www.cryptopp.com.
--- 
You received this message because you are subscribed to the Google Groups 
"Crypto++ Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to cryptopp-users+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to