Am 12.01.2018 14:26 schrieb "Jeffrey Walton" <[email protected]>:
On Friday, January 12, 2018 at 8:03:42 AM UTC-5, Jeffrey Walton wrote: > > On Fri, Jan 12, 2018 at 7:28 AM, Andrew Marlow <[email protected]> > wrote: > > Hello everyone, > > > > I just tried to build cryptopp 565 on Windows 10 using Visual Studio > 2017 > > with the update for toolset v141 (by default it is v140). I got a > > compilation warning: > > > > 1>[snip]thirdparty-source\cryptopp\wait.h(159): warning C4589: > Constructor > > of abstract class 'CryptoPP::WaitObjectsTracer' ignores initializer for > > virtual base class 'CryptoPP::Tracer' > > 1>[snip]thirdparty-source\cryptopp\wait.h(159): note: virtual base > classes > > are only initialized by the most-derived type > > > > Obviously this is just a warning so it is not urgent. I merely report it > so > > it might get fixed at some point in the future. > > Thanks Andrew. Also see https://github.com/weidai11/cryptopp/issues/214 > Another attempt: https://github.com/weidai11/cryptopp/commit/c6289edd4481 . Jeff Hmm, that shouldn't change anything for now. The latest VS 2017.6's _MSC_VER is 1913. But better suppress the warning for future versions than having to suppress it again for every new VS release and having people complain for new VS versions with older Crypto++ versions :-) I just tested changing the warning(suppress) to warning(error) and the warning is still issued in the latest VS preview. But the only suppression needed is the one in wait.h, there are a few more in .cpp files. Andrew, you're probably using Crypto++ 5.6.5 without patches? The warning got suppressed for VS 2017 after the release in git master. Crypto++ 5.6.5 is older than VS 2017. Marcel -- You received this message because you are subscribed to "Crypto++ Users". More information about Crypto++ and this group is available at http://www.cryptopp.com and http://groups.google.com/forum/#!forum/cryptopp-users. --- You received this message because you are subscribed to the Google Groups "Crypto++ Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
