On 02.01.2006 06:19, Michael D. Adams wrote: > In csMouseDriver::DoButton on line libs/csutil/csinput.cpp:668 the > call to csMouseEventHelper::NewEvent is ambiguous because the axes and > numAxes parameters don't quite match. They are declared to be const > int32* and uint, but NewEvent expects const int* and uint8. Should > NewEvent be changed to use int32 and uint or should DoButton be > changed to use int and uint8? Note that the later would require > changing the signature of DoButton (axes is a parameter of that > function).
int32 I think, since that is what is used everywhere below NewEvent, e.g. for setting the event property. Although you could do an int->int32 conversion in DoButton(), I think it's IMO not too much to ask to have the axes provides as int32*. For the axes count... a cast to uint8 should be okay, if needed. There should be checks that the axes number does not exceed CS_MAX_MOUSE_AXES etc. -f.r.
signature.asc
Description: OpenPGP digital signature
