On 1/11/06, Razor <[EMAIL PROTECTED]> wrote:
> Problem description (CS, current CVS):
> Under Linux, an application only receives a keyboard event from the numpad5
> key if numlock is off.  Numlock on results in no message being sent when
> numpad5 is pressed.
>
> Problem resolution:
> I have traced the problem to a missing MAP_KEY (...) statement in
> plugins/video/canvas/xwindow/xwindow.cpp
> I have included a small diff file which resolves this issue.

The patch looks right. But I don't have a Linux box to test it on.  If
no one else has committed (and tested it on Linux) it by next Tuesday
(I'm very busy until then), then remind me and I can blind commit it.

FYI: The "normal" format produced by 'diff' and 'cvs diff' is not very
good for sending patches because it doesn't show the context of the
patch.  If the line numbers of the source file change before your
patch is applied, then the patch will mess-up.  You should use 'diff
-u' or 'cvs diff -u' instead.  It produces "unified" format that
includes context.  Such patches are more likely to be applied sooner
by most developers.  (Also the patch file is missing the file header,
I don't know why.)

I've included an example of a well formed diff at the end of this file
so you know what they should look like.  If your diff comes from CVS,
it may have additional lines.  They don't hurt anything so they can be
left in.

Michael D. Adams
[EMAIL PROTECTED]

--- crystal/CS/docs/history.old 2004/08/02 23:22:12     1.28
+++ crystal/CS/docs/history.old 2004/08/27 15:38:11     1.29
@@ -20636,7 +20636,7 @@
          experienced by non-OS/2 ports.
        - Eric Sunshine fixed the next2d canvas so that it once again builds
          successfully.  It broke on 2001/12/27.
-       - Eric Sunshined changed the next2d canvas so that it no longer bothers
+       - Eric Sunshine changed the next2d canvas so that it no longer bothers
          to register the iEventHandler implementor with the event queue in
          NeXTDriver2D::Initialize(), since its superclass'
          csGraphics2D::Initialize() already does so.  (No need to register the
@@ -23952,7 +23952,7 @@
          release the CPU on platforms which employ a native black-box run-loop
          mechanism.  It also causes the native user environment to incorrectly
          hang, and is therefore a bad-thing.
-       - Eric Sunshined added a implementation of csSleep() to the BeOS port.
+       - Eric Sunshine added a implementation of csSleep() to the BeOS port.
        - Eric Sunshine eliminated an "unused variable" warning from
          ogl_g3dcom.cpp.
        - Norman Kramer removed the "old" mp3 parts (which only played layer


-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_idv37&alloc_id865&op=click
_______________________________________________
Crystal-main mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/crystal-main
Unsubscribe: mailto:[EMAIL PROTECTED]

Reply via email to