On 24.09.2013 10:46, Roberto E. Vargas Caballero wrote:

> Patch 0001: Use VISUAL variable when it is avaible and the terminal is not a
>           dumb terminal. I have to add this patch because I usually have to
>           connect to system which terminal interfaces dumb type, so my
>           EDITOR and VISUAL variables have different values, but I usually
>           want see sources with vi and not with ex.

Actually you don't need to change the code at all to get that effect. 
CSCOPE_EDITOR exists, and does what you want to use VISUAL for.

> Patch 0002: This patch is only a small addition to the manual page, because
>           the assignmenet case was not showed in it.

Accepted as-is.

> Patch 0003: This patch adds a way of filtering the results in finddef 
> function,
>           since we have information about the kind of symbol. I have add
>           a solution which doesn't increment the number of options in the
>           graphical interface (it is already big), and it is basically
>           add the kind of definition in the search pattern. I don't have
>           modified the manual page, because I don't know if this change
>           will be good for you.

I'm tending to reject this, on the basis of it modifying more than it 
really should. The character '@' isn't quite as forbidden to appear in 
search patterns as you might think.  Many people are using cscope on 
untopical input.  Those would hate us for making @ unusable in searches.

------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from 
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60133471&iu=/4140/ostg.clktrk
_______________________________________________
Cscope-devel mailing list
Cscope-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/cscope-devel

Reply via email to