Hi Lars, Did you get a chance to review the patch?
If you see a need for any additions/corrections to be made, then do let me know so that i can work on updating the patch accordingly. Thanks and Regards, Samba ======================================================================= On Tue, Aug 7, 2012 at 4:42 PM, Lars Ellenberg <lars.ellenb...@linbit.com>wrote: > On Mon, Aug 06, 2012 at 07:13:16PM +0530, Samba wrote: > > Lars, > > I apologise for pushing this one a bit fast but i feel it is better to > get > > the issue fixed in the trunk so that we do not have any PRIVATE changes > in > > our repository. > > > > Further, having the patch committed to the trunk will give assurance the > > fix is code reviewed and tested properly. > > > > If you have any suggestions/corrections, then do let me know so that I > can > > incorporate those and submit an updated patch. > > > > You may also suggest verifying specific test cases in order to ensure > > better test coverage and avoid regression. > > > > I really appreciate the fact that you and other commiters put extra > efforts > > on top on your normal day-job for making this software available to > users > > like us. I do know that it needs passion for the project and commitment > for > > open source. > > > > I hope you would find some time amidst your busy schedule to review the > > patch and commit it to the trunk. > > I'm finally on vacation, so I may find time tonight to leisurely commit > a few patches ;-) > > > > > > Thanks and Regards, > > Samba > > > > PS: > > Alternatively, how about inviting review comments from other users in the > > community so that we can offload the efforts to some extent. I can guess > > that many users would be needing a fix for the issue of 'sync failure > > during subdir deletion' so those folks can take this patch and review if > > possible or at least test and verify that it works for them. In this way > we > > can build an community over the project and ensure that every patch is > > actually reviewed and tested well before getting committed to the trunk. > > > Additional review is always a nice bonus. > > So if anyone would like to comment, please step forward... > > Lars >
_______________________________________________ Csync2 mailing list Csync2@lists.linbit.com http://lists.linbit.com/mailman/listinfo/csync2
