[ 
https://issues.apache.org/jira/browse/CTAKES-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482683#comment-13482683
 ] 

Steven Bethard commented on CTAKES-28:
--------------------------------------

It would be really nice if you could supply these as Java properties, e.g. run 
java with:

-Dumls.user=...
-Dumls.password=...

This could be as simple as adding to UmlsDictionaryLookupAnnotator.java

+      UMLSUser = System.getProperty("umls.user");
+      if (UMLSUser == null) {
                        UMLSUser = (String) 
iv_context.getConfigParameterValue(UMLSUSER_PARAM);
+      }
+      UMLSPW = System.getProperty("umls.password");
+      if (UMLSPW == null) {
                        UMLSPW = (String) 
iv_context.getConfigParameterValue(UMLSPW_PARAM);
+      }

                
> Externalize dictionarylookup/UMLS password to password file or variable
> -----------------------------------------------------------------------
>
>                 Key: CTAKES-28
>                 URL: https://issues.apache.org/jira/browse/CTAKES-28
>             Project: cTAKES
>          Issue Type: Improvement
>          Components: ctakes-dictionary-lookup
>            Reporter: Pei Chen
>            Priority: Minor
>
> Moved from SF Traker: 3486359 
> To avoid users accidently checking in the UMLS configuration file with pw, it 
> would be good to externalize it so that the pw is stored to an external file. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to