On Wed, May 14, 2014 at 09:52:04AM +0100 I heard the voice of
Aaron Sloman, and lo! it spake thus:
>
> and finally:
> ......
> mwmhints.c: In function `GetMWMHints':
> mwmhints.c:60: parse error before `int'
> mwmhints.c:67: `success' undeclared (first use in this function)
[...]
Probably complaining about the intermingled declarations. Try
attached patch; should let it get through there. It's interesting
that -std=c89 (which I did run) didn't catch those.
> I'm surprised it managed to get that far as everything on this
> machine is ancient. The newest files in /usr/bin are dated 2007
>
> I think I'll abandon Solaris. Maybe someone with a newer version
> (someone from Oracle?) will try: the signs are fairly promising.
It would be good to keep working it, if you've got the time. 2007 is
old by most standards, but as systems ctwm [purportedly at least]
supports, it's almost too new to think about yet. I mean, we've got
checks in code for SysVR4, and Ultrix, and NeXT, and NeWS, and
Sequent, and AIX 3.x, and QNX, and beyond. SunOS 5.10^W^WSolaris
2.10^W10 shouldn't be that hard...
Now, I will say that my post-3.8.2 plans _do_ include potentially
shucking a lot of that, and officially de-supporting a lot of older
stuff, especially if nobody here is using them. That's a whole
'nother thread, of course. But still, Sol 10 isn't that old, it's
probably just a minor tweak here and there to get it going.
--
Matthew Fuller (MF4839) | [email protected]
Systems/Network Administrator | http://www.over-yonder.net/~fullermd/
On the Internet, nobody can hear you scream.
=== modified file 'mwmhints.c'
--- mwmhints.c 2014-05-09 12:49:18 +0000
+++ mwmhints.c 2014-05-14 10:57:14 +0000
@@ -44,6 +44,13 @@
int GetMWMHints(Window w, MotifWmHints *mwmHints)
{
+ int success;
+ Atom actual_type;
+ int actual_format;
+ unsigned long nitems;
+ unsigned long bytes_after;
+ unsigned long *prop = NULL;
+
/* Defaults for when not found */
mwmHints->flags = 0;
mwmHints->functions = 0;
@@ -57,13 +64,6 @@
MOTIF_WM_HINTS = XInternAtom(dpy, "_MOTIF_WM_HINTS", True);
}
- int success;
- Atom actual_type;
- int actual_format;
- unsigned long nitems;
- unsigned long bytes_after;
- unsigned long *prop = NULL;
-
success = XGetWindowProperty(
dpy, w, MOTIF_WM_HINTS,
0, 5, /* long_offset, long long_length, */
