In message <[email protected]> on Sun, 19 Jul 2015
05:12:10 -0500, "Matthew D. Fuller" <[email protected]> said:
fullermd> On Sun, Jul 19, 2015 at 11:49:35AM +0200 I heard the voice of
fullermd> Richard Levitte, and lo! it spake thus:
fullermd> >
fullermd> > I'm getting all kinds of other warnings about poorly declared
fullermd> > symbols, but that's helped by defining _XOPEN_SOURCE and sometimes
fullermd> > _XOPEN_SOURCE_EXTENDED... which I'd recommend over _POSIX_C_SOURCE,
fullermd> > btw; it seems more consistent.
fullermd>
fullermd> Odd; I'm setting both _POSIX_C_SOURCE and _XOPEN_SOURCE in
fullermd> ctwm_config.h, to the highest levels Fedora 22's features.h knows
fullermd> about. And that level of _XOPEN_SOURCE _does_ cause
fullermd> __USE_XOPEN_EXTENDED to be defined as well. So you shouldn't be
fullermd> getting those warnings, or alternately, #define'ing yourself shouldn't
fullermd> fix them since the defines are already set.
Oh, it seems like I wasn't as up to date as I thought...
Much better
fullermd> > I hope it's ok that I just commit when I'm done (sorry for the
fullermd> > tip-toeing, but I've been away for so long...)
fullermd>
fullermd> Well, if it's sprinking #define _{POSIX,XOPEN} around the .c files, I
fullermd> 'druther look at it from the "what's {cmake,ctwm_config.h} doing
fullermd> wrong" perspective so we can have the fix in one place rather than
Diagnosis: shit behind the wheel ;-)
fullermd> I'm trying to optimize things for the poor schmuck in 2035 who's
fullermd> looking at one of these files and asking "What the heck is this line
fullermd> here for, what if anything is it still needed for, and how can I
fullermd> possibly know what'll break if it I take it out?" I want to keep all
fullermd> THAT fun for myself 8-}
Heh, I know the feeling
--
Richard Levitte [email protected]
http://richard.levitte.org/
"Life is a tremendous celebration - and I'm invited!"
-- from a friend's blog, translated from Swedish
